Skip to content

feat: spec.secrets must be existing secrets#1961

Open
alex1989hu wants to merge 4 commits intopercona:mainfrom
alex1989hu:feat/ensure-secret-existence
Open

feat: spec.secrets must be existing secrets#1961
alex1989hu wants to merge 4 commits intopercona:mainfrom
alex1989hu:feat/ensure-secret-existence

Conversation

@alex1989hu
Copy link
Copy Markdown

@alex1989hu alex1989hu commented Jun 5, 2025

CHANGE DESCRIPTION

Problem:
#1960

Cause:
This is the current logic of the code.

Solution:
Make sure that secrets specified in the manifest are preserved and not overwritten by the operator.

Closes #1960

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Jun 5, 2025
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 5, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gkech gkech added the community label Jun 5, 2025
@alex1989hu
Copy link
Copy Markdown
Author

Before fixing unit test and E2E failures I'd like to discuss the approach. Please see the comment here #1960 (comment)

@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels Jun 6, 2025
@hors
Copy link
Copy Markdown
Collaborator

hors commented Jun 21, 2025

Before fixing unit test and E2E failures I'd like to discuss the approach. Please see the comment here #1960 (comment)

Hi @alex1989hu,
Thanks for your contribution! Due to team vacations, we’re currently experiencing some delays in reviewing PRs. We’ll review your suggestion and provide feedback within a week. Appreciate your patience!

@egegunes egegunes assigned gkech and unassigned egegunes Jun 30, 2025
@egegunes
Copy link
Copy Markdown
Contributor

@gkech could you please check this?

@egegunes
Copy link
Copy Markdown
Contributor

@gkech please check this when you have the chance

Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
@alex1989hu alex1989hu force-pushed the feat/ensure-secret-existence branch from 7f9b8fd to 0fa7592 Compare February 12, 2026 18:32
@JNKPercona
Copy link
Copy Markdown
Collaborator

Test Name Result Time
arbiter passed 00:11:38
balancer passed 00:18:24
cross-site-sharded passed 00:18:51
custom-replset-name passed 00:09:59
custom-tls passed 00:14:52
custom-users-roles passed 00:10:34
custom-users-roles-sharded passed 00:11:46
data-at-rest-encryption passed 00:12:49
data-sharded passed 00:22:47
demand-backup passed 00:16:10
demand-backup-eks-credentials-irsa passed 00:00:08
demand-backup-fs passed 00:23:07
demand-backup-if-unhealthy passed 00:10:20
demand-backup-incremental-aws passed 00:12:09
demand-backup-incremental-azure passed 00:11:59
demand-backup-incremental-gcp-native passed 00:11:47
demand-backup-incremental-gcp-s3 passed 00:10:53
demand-backup-incremental-minio passed 00:25:48
demand-backup-incremental-sharded-aws passed 00:19:01
demand-backup-incremental-sharded-azure passed 00:18:10
demand-backup-incremental-sharded-gcp-native passed 00:17:20
demand-backup-incremental-sharded-gcp-s3 passed 00:17:29
demand-backup-incremental-sharded-minio passed 00:27:32
demand-backup-physical-parallel passed 00:08:21
demand-backup-physical-aws passed 00:12:35
demand-backup-physical-azure passed 00:11:45
demand-backup-physical-gcp-s3 passed 00:11:54
demand-backup-physical-gcp-native passed 00:12:28
demand-backup-physical-minio passed 00:20:32
demand-backup-physical-minio-native passed 00:26:50
demand-backup-physical-minio-native-tls passed 00:19:53
demand-backup-physical-sharded-parallel passed 00:11:29
demand-backup-physical-sharded-aws passed 00:18:13
demand-backup-physical-sharded-azure passed 00:17:37
demand-backup-physical-sharded-gcp-native passed 00:17:46
demand-backup-physical-sharded-minio passed 00:17:49
demand-backup-physical-sharded-minio-native passed 00:17:46
demand-backup-sharded passed 00:26:27
disabled-auth passed 00:16:52
expose-sharded passed 00:34:11
finalizer passed 00:10:11
ignore-labels-annotations failure 01:30:09
init-deploy passed 00:13:30
ldap passed 00:09:11
ldap-tls passed 00:12:38
limits failure 01:30:00
liveness passed 00:09:05
mongod-major-upgrade passed 00:12:26
mongod-major-upgrade-sharded passed 00:20:29
monitoring-2-0 passed 00:25:09
monitoring-pmm3 passed 00:27:11
multi-cluster-service passed 00:14:01
multi-storage passed 00:18:53
non-voting-and-hidden passed 00:17:07
one-pod passed 00:07:38
operator-self-healing-chaos passed 00:12:54
pitr passed 00:32:27
pitr-physical passed 01:01:48
pitr-sharded passed 00:23:05
pitr-to-new-cluster passed 00:25:37
pitr-physical-backup-source passed 00:55:54
preinit-updates failure 01:30:09
pvc-auto-resize passed 00:13:37
pvc-resize passed 00:16:33
recover-no-primary passed 00:28:10
replset-overrides passed 00:18:09
replset-remapping passed 00:17:05
replset-remapping-sharded passed 00:18:04
rs-shard-migration passed 00:14:07
scaling passed 00:11:33
scheduled-backup passed 00:17:57
security-context passed 00:07:02
self-healing-chaos passed 00:15:32
service-per-pod passed 00:19:32
serviceless-external-nodes passed 00:07:32
smart-update passed 00:08:07
split-horizon passed 00:14:06
stable-resource-version failure 01:30:07
storage passed 00:07:34
tls-issue-cert-manager passed 00:29:47
unsafe-psa passed 00:07:26
upgrade passed 00:10:04
upgrade-consistency passed 00:07:45
upgrade-consistency-sharded-tls passed 00:57:14
upgrade-sharded passed 00:19:39
upgrade-partial-backup passed 00:16:52
users failure 00:05:21
users-vault failure 01:30:06
version-service passed 00:25:04
Summary Value
Tests Run 89/89
Job Duration 03:57:01
Total Test Time 32:10:25

commit: 0fa7592
image: perconalab/percona-server-mongodb-operator:PR-1961-0fa7592e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defined secrets should be treated as existing secrets

6 participants