Skip to content

K8SPG-991: fix cleaning up outdated backups #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmarukovich wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −1
Open

K8SPG-991: fix cleaning up outdated backups #1526

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4292149
K8SPG-740 fix
nmarukovich Mar 26, 2026
2f99721
Merge branch 'main' into K8SPG-740_fix_under_update
eleo007 Mar 27, 2026
a59eea5
Merge branch 'main' into K8SPG-740_fix_under_update
nmarukovich Mar 30, 2026
cb0d782
Merge branch 'main' into K8SPG-740_fix_under_update
nmarukovich Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion percona/controller/pgcluster/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package pgcluster

import (
"context"
"strings"

"github.com/pkg/errors"
batchv1 "k8s.io/api/batch/v1"
Expand Down Expand Up @@ -71,7 +72,8 @@ func (r *PGClusterReconciler) cleanupOutdatedBackups(ctx context.Context, cr *v2

readyPod, err := controller.GetReadyInstancePod(ctx, r.Client, cr.Name, cr.Namespace)
if err != nil {
return errors.Wrap(err, "get ready instance pod")
log.Info("No ready instance pod found, skipping backup cleanup", "repo", repo.Name, "reason", err.Error())
continue
}
info, err = pgbackrest.GetInfo(ctx, readyPod, repo.Name)
if err != nil {
Expand All @@ -83,6 +85,10 @@ func (r *PGClusterReconciler) cleanupOutdatedBackups(ctx context.Context, cr *v2
log.Info("pgBackRest stanza not yet created, skipping backup cleanup", "repo", repo.Name)
continue
}
if strings.Contains(err.Error(), "container not found") {
log.Info("Container not ready, skipping backup cleanup", "repo", repo.Name, "reason", err.Error())
continue
}
return errors.Wrap(err, "get pgBackRest info")
}

Expand Down
Loading