Skip to content

K8SPG-737 Make mountPoint configurable in node_exporter #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nmarukovich wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

K8SPG-737 Make mountPoint configurable in node_exporter #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
433465e
K8SPG-737 add path
nmarukovich Feb 19, 2026
169031a
turn off test step
nmarukovich Feb 26, 2026
fd9fad7
Merge branch 'main' into K8SPG-737
nmarukovich Feb 26, 2026
0f9d77d
Merge branch 'main' into K8SPG-737
hors Feb 26, 2026
58f48b9
Merge branch 'main' into K8SPG-737
nmarukovich Mar 4, 2026
6491c02
Merge branch 'main' into K8SPG-737
nmarukovich Mar 5, 2026
d9dd4a2
merge main
nmarukovich Apr 8, 2026
b9e4561
rename var
nmarukovich Apr 8, 2026
0eda4e4
Merge branch 'K8SPG-737' of github.com:percona/percona-postgresql-ope…
nmarukovich Apr 8, 2026
62f022a
uncomment test case
nmarukovich Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions e2e-tests/tests/monitoring-pmm3/08-check-mountpoint-expose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
apiVersion: kuttl.dev/v1beta1
kind: TestStep
commands:
- script: |-
set -o errexit
set -o xtrace

source ../../functions

series_fetched=$(curl --insecure -G "https://admin:admin@$(get_service_ip monitoring-service)/prometheus/api/v1/query_range" \
--data-urlencode "query=node_filesystem_free_bytes{mountpoint=\"/pgdata\"}" \
--data-urlencode "start=$(($(date +%s) - 300))" \
--data-urlencode "end=$(date +%s)" \
--data-urlencode "step=5s" | jq -r '.stats.seriesFetched')

if [[ $series_fetched == 0 ]]; then
echo "seriesFetched is 0"
exit 1
fi
timeout: 360
Comment on lines +1 to +20
Copy link
Copy Markdown
Contributor

@gkech gkech Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this node_exporter task is going to be merged? Asking because maybe it is best to remove these todos and the commenting and merge this PR only when the respective node_exporter PR is merged.

Copy link
Copy Markdown
Contributor Author

@nmarukovich nmarukovich Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean we should remove only this part, i.e. the tests, or hold off on the whole PR?
I would prefer not to delay the entire PR, because that could leave us waiting quite a while for both the PMM release and our own release.
If we merge it now, we will be able to use it as soon as PMM is released.
Can you explain a bit more why you think the whole PR should wait?

Copy link
Copy Markdown
Contributor

@gkech gkech Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so are we going to be merge it with these tests commented out? I dont fully understand whats the plan.

0 ...nitoring-pmm3/08-check-password-leak.yaml → ...nitoring-pmm3/09-check-password-leak.yaml
View file
Open in desktop
File renamed without changes.
20 changes: 20 additions & 0 deletions e2e-tests/tests/monitoring/08-check-mountpoint-expose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
apiVersion: kuttl.dev/v1beta1
kind: TestStep
commands:
- script: |-
set -o errexit
set -o xtrace

source ../../functions
# TODO: turn on after changes in PMM: PMM-14832
# series_fetched=$(curl --insecure -G "https://admin:admin@$(get_service_ip monitoring-service)/prometheus/api/v1/query_range" \
# --data-urlencode "query=node_filesystem_free_bytes{mountpoint=\"/pgdata\"}" \
# --data-urlencode "start=$(($(date +%s) - 300))" \
# --data-urlencode "end=$(date +%s)" \
# --data-urlencode "step=5s" | jq -r '.stats.seriesFetched')
#
# if [[ $series_fetched == 0 ]]; then
# echo "seriesFetched is 0"
# exit 1
# fi
timeout: 360
Loading
Loading