Skip to content

Conversation

@nastena1606
Copy link
Collaborator

modified: docs/features/physical.md
modified: docs/troubleshoot/faq.md
modified: docs/usage/restore-physical.md

modified:   docs/features/physical.md
        modified:   docs/troubleshoot/faq.md
        modified:   docs/usage/restore-physical.md
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents the automatic retry mechanism for Location50917 errors during physical backup operations as a new FAQ item, and reorganizes content in the physical backup documentation.

  • Added a new FAQ entry explaining PBM's automatic retry behavior for Location50917 errors introduced in version 2.13.0
  • Reformatted physical backup/restore documentation by moving content sections earlier in the document
  • Improved readability of restore progress tracking instructions by breaking into separate paragraphs

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/troubleshoot/faq.md Added FAQ entry about Location50917 error handling with automatic retry details
docs/features/physical.md Moved physical backup/restore definition and comparison table to appear earlier in the document
docs/usage/restore-physical.md Reformatted restore progress tracking section into separate paragraphs for better readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| [2.3.0](../release-notes/2.3.0.md) | Physical backups in mixed deployments |
| [2.10.0](../release-notes/2.10.0.md) | Physical restore with a fallback directory |

**Physical backup** is copying of physical files from the Percona Server for MongoDB `dbPath` data directory to the remote backup storage. These files include data files, journal, index files, etc. Percona Backup for MongoDB also copies the WiredTiger storage options to the backup's metadata.
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moved paragraph now states 'Percona Backup for MongoDB also copies the WiredTiger storage options' without specifying the version when this feature was added. The original text mentioned 'Starting with version 2.0.0' which provided important version context. Consider adding this version information back to maintain historical accuracy.

Suggested change
**Physical backup** is copying of physical files from the Percona Server for MongoDB `dbPath` data directory to the remote backup storage. These files include data files, journal, index files, etc. Percona Backup for MongoDB also copies the WiredTiger storage options to the backup's metadata.
**Physical backup** is copying of physical files from the Percona Server for MongoDB `dbPath` data directory to the remote backup storage. These files include data files, journal, index files, etc. Starting with version 2.0.0, Percona Backup for MongoDB also copies the WiredTiger storage options to the backup's metadata.

Copilot uses AI. Check for mistakes.
Copy link
Member

@boris-ilijic boris-ilijic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine to document this although it's very related to system internals. Also, we already have the same type of retry logic for the other type of error during physical backup, but we haven't covered that in the docs:
https://perconadev.atlassian.net/browse/PBM-803

@nastena1606
Copy link
Collaborator Author

I am fine to document this although it's very related to system internals. Also, we already have the same type of retry logic for the other type of error during physical backup, but we haven't covered that in the docs: https://perconadev.atlassian.net/browse/PBM-803

Boris, do you think it's worth documenting the behavior in PBM-803?

@boris-ilijic
Copy link
Member

boris-ilijic commented Dec 29, 2025

do you think it's worth documenting the behavior in PBM-803?

I would expand provided description with both errors. Technically it's the similar type of error (the same category) and it'll be fixed automatically during the retry. Therefore if we are mentioning first one, let's mention also the other one and have the full story about that topic.

@nastena1606
Copy link
Collaborator Author

do you think it's worth documenting the behavior in PBM-803?

I would expand provided description with both errors. Technically it's the similar type of error (the same category) and it'll be fixed automatically during the retry. Therefore if we are mentioning first one, let's mention also the other one and have the full story about that topic.

Done. @boris-ilijic will appreciate another review from you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants