[BACKLOG-36846] Setting Focus on Textbox#5214
Open
jyotir1245 wants to merge 1 commit intopentaho:wcagfrom
Open
[BACKLOG-36846] Setting Focus on Textbox#5214jyotir1245 wants to merge 1 commit intopentaho:wcagfrom
jyotir1245 wants to merge 1 commit intopentaho:wcagfrom
Conversation
[BACKLOG-36846] Setting Focus on Textbox
Collaborator
✅ Build finished in 10m 39sBuild command: mvn clean verify -B -e -Daudit -amd -pl user-console👌 All tests passed! Tests run: 12, Failures: 0, Skipped: 0 Test Results ℹ️ This is an automatic message |
|
SonarQube Quality Gate
|
Contributor
|
Follows from: #5210 |
dcleao
requested changes
Feb 6, 2023
| AbstractWizardDialog.ScheduleDialogType.SCHEDULER ); | ||
| editSchedule.setShowSuccessDialog( false ); | ||
| editSchedule.addCustomPanel( scheduleLabelPanel, DockPanel.NORTH ); | ||
| editSchedule.setFocusWidget( scheduleTextBox ); |
Contributor
There was a problem hiding this comment.
Like previously said in #5210 (comment), I believe that you should not need to call setFocusWidget( . ).
Is it not the first "tababble" element of the dialog?
If the code which sets the default focus is failing, we should fix that instead. See https://github.com/pentaho/pentaho-commons-gwt-modules/blob/wcag/widgets/src/main/java/org/pentaho/gwt/widgets/client/dialogs/DialogBox.java#L204.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please review, @pentaho/wcag