Skip to content

feat(Theme): update shadows on the Pentaho theme to the latest specs#5145

Merged
zettca merged 2 commits intomasterfrom
feat/shadows
Apr 20, 2026
Merged

feat(Theme): update shadows on the Pentaho theme to the latest specs#5145
zettca merged 2 commits intomasterfrom
feat/shadows

Conversation

@plagoa
Copy link
Copy Markdown
Contributor

@plagoa plagoa commented Apr 17, 2026

  • Update default shadow definition on the Pentaho theme to the latest spec
  • Add custom overrides to the HvDialog and HvTooltip components
  • Add shadows to components that didn't have shadow before: HvCard and HvSnackbar

@plagoa plagoa requested a review from a team as a code owner April 17, 2026 10:37
Copilot AI review requested due to automatic review settings April 17, 2026 10:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Pentaho theme’s shadow tokens and component-level shadow styling to match the latest visual specs across the shared styles package and the core component theme overrides.

Changes:

  • Updated the Pentaho theme colors.shadow token to a new multi-layer shadow definition.
  • Updated popper-based surfaces to the new shadow and added custom shadow overrides for HvDialog and HvTooltip.
  • Added shadows to components that previously had none in the Pentaho core theme overrides (HvCard, HvSnackbarContent).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/styles/src/themes/pentaho.ts Updates the base Pentaho colors.shadow token used across the design system.
packages/core/src/themes/pentaho.ts Aligns component/theme overrides (poppers, dialog, tooltip, card, snackbar content) with the updated shadow specs.

Comment thread packages/core/src/themes/pentaho.ts Outdated
Comment thread packages/core/src/themes/pentaho.ts Outdated
Comment thread packages/core/src/themes/pentaho.ts Outdated
@github-actions github-actions Bot temporarily deployed to uikit-docs/pr-5145 April 17, 2026 10:41 Destroyed
@github-actions github-actions Bot temporarily deployed to uikit-docs/pr-5145 April 17, 2026 10:54 Destroyed
@github-actions github-actions Bot temporarily deployed to uikit-docs/pr-5145 April 20, 2026 10:24 Destroyed
Comment thread packages/core/src/themes/pentaho.ts Outdated
classes: {
paper: {
borderRadius: theme.radii.large,
boxShadow: `0 32px 32px 0 ${theme.alpha(slate[900], 0.1)}, 0 20px 20px 0 ${theme.alpha(slate[900], 0.08)}, 0 12px 12px 0 ${theme.alpha(slate[900], 0.06)}, 0 5px 5px 0 ${theme.alpha(slate[900], 0.04)}, 0 1px 1px 0 ${theme.alpha(slate[900], 0.02)}`,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we promote this to a variable, like we do in other "component"/internal tokens?
so it's easier to understand the PD mapping & its reusable?

ie

const shadows = {
  container: theme.colors.shadow, // we can also omit this
  elevated: `0 32....`
  modal: `0 ...`
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this change 👍

Comment thread packages/core/src/themes/pentaho.ts
@zettca zettca merged commit 6afc7a6 into master Apr 20, 2026
17 checks passed
@zettca zettca deleted the feat/shadows branch April 20, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants