feat(Theme): update shadows on the Pentaho theme to the latest specs#5145
Merged
feat(Theme): update shadows on the Pentaho theme to the latest specs#5145
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Pentaho theme’s shadow tokens and component-level shadow styling to match the latest visual specs across the shared styles package and the core component theme overrides.
Changes:
- Updated the Pentaho theme
colors.shadowtoken to a new multi-layer shadow definition. - Updated popper-based surfaces to the new shadow and added custom shadow overrides for
HvDialogandHvTooltip. - Added shadows to components that previously had none in the Pentaho core theme overrides (
HvCard,HvSnackbarContent).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/styles/src/themes/pentaho.ts | Updates the base Pentaho colors.shadow token used across the design system. |
| packages/core/src/themes/pentaho.ts | Aligns component/theme overrides (poppers, dialog, tooltip, card, snackbar content) with the updated shadow specs. |
francisco-guilherme
approved these changes
Apr 17, 2026
zettca
reviewed
Apr 20, 2026
| classes: { | ||
| paper: { | ||
| borderRadius: theme.radii.large, | ||
| boxShadow: `0 32px 32px 0 ${theme.alpha(slate[900], 0.1)}, 0 20px 20px 0 ${theme.alpha(slate[900], 0.08)}, 0 12px 12px 0 ${theme.alpha(slate[900], 0.06)}, 0 5px 5px 0 ${theme.alpha(slate[900], 0.04)}, 0 1px 1px 0 ${theme.alpha(slate[900], 0.02)}`, |
Member
There was a problem hiding this comment.
can we promote this to a variable, like we do in other "component"/internal tokens?
so it's easier to understand the PD mapping & its reusable?
ie
const shadows = {
container: theme.colors.shadow, // we can also omit this
elevated: `0 32....`
modal: `0 ...`
}
Contributor
Author
There was a problem hiding this comment.
I'll make this change 👍
zettca
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HvDialogandHvTooltipcomponentsHvCardandHvSnackbar