fix(AppShell): invalid menus no target nor submenu are now filtered out#5142
Merged
fix(AppShell): invalid menus no target nor submenu are now filtered out#5142
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Filters out invalid App Shell menu items at runtime so they don’t render (or cause downstream UI issues) when a menu entry has neither a navigation target nor submenus.
Changes:
- Update
filterMenusto drop leaf menu entries that have notarget. - Add unit tests covering invalid leaf menus and submenu-driven disappearance scenarios.
- Extend the default app config with sample menu entries to exercise/illustrate the behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/app-shell-ui/src/utils/filterModel.ts |
Skips leaf menu items that lack both submenus and target. |
packages/app-shell-ui/src/utils/filterModel.test.ts |
Adds coverage for invalid menu filtering and parent/submenu condition interactions. |
apps/default-app/app-shell.config.ts |
Adds example menu entries, including a deliberately invalid one (no target/submenus). |
loonatic
force-pushed
the
fix/menus-without-target
branch
from
196d550 to
f4be824
Compare
davidmsantos90
approved these changes
Apr 14, 2026
dcleao
approved these changes
Apr 15, 2026
zettca
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.