Various CI improvements suggested by zizmor#2139
Various CI improvements suggested by zizmor#2139bjorn3 wants to merge 12 commits intopendulum-project:mainfrom
Conversation
* A bunch of explicit read permissions are removed as they are implicit for public repos. * add-prs-to-project no longer has write permissions * docs no longer has write permissions during the build step, only during the deploy step.
This prevents any potential cache poisoning. The actual build already wasn't cached and likely takes much longer than downloading packages.
This avoids what I believe to be a false positive from zizmor about github.api_url being potentially attacker controlled.
This avoids depending on an external action.
This fixes a zizmor complaint about template-injection.
| packages: write | ||
|
|
||
| on: | ||
| workflow_call: {} |
There was a problem hiding this comment.
@rnijveld I think we dont use this, but am not a 100% sure.
| - i686-unknown-linux-gnu | ||
| steps: | ||
| - name: Setup packaging tools for cross compiled artifacts | ||
| uses: awalsh128/cache-apt-pkgs-action@acb598e5ddbc6f68a970c5da0688d2f3a9f04d05 # v1.6.0 |
There was a problem hiding this comment.
@rnijveld was there a specific reason we used caching here?
| test "$release_notes_version" == "${release_version}" | ||
| echo "$release_notes_body" > release_notes.md | ||
|
|
||
| - name: Create release |
There was a problem hiding this comment.
I think this should keep the original title.
| - name: Create release | |
| - name: Create a draft release |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
==========================================
- Coverage 83.57% 83.54% -0.04%
==========================================
Files 71 71
Lines 20007 20007
==========================================
- Hits 16721 16714 -7
- Misses 3286 3293 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
https://zizmor.sh/ is a static analysis tool for github actions. @hashcatHitman suggested using this.