My re-write of the two existing OS X Defaults modules#7
Open
llauren wants to merge 3 commits intopebbleit:masterfrom
Open
My re-write of the two existing OS X Defaults modules#7llauren wants to merge 3 commits intopebbleit:masterfrom
llauren wants to merge 3 commits intopebbleit:masterfrom
Conversation
* Expanded the clever boolean `unless` code to make it more boring and readable * Added checks for the parameters * Updated requirement for stdlib to version 4, which provides `assert_type` * Added a license (BSD Simplified/2-clause; licenses are boring) * Removed bugs
Contributor
|
This module has been abandoned. I no longer have any access to the repo so I cannot take it offline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Since your OS X Defaults module wasn't compatible with Puppet 4, i decided to give it a little re-write. I mashed together your code with Will Farrington's (@wfarr https://github.com/wfarr/puppet-osx_defaults). I also just realised that i removed both of you from the metadata, which is kind of rude now that i think of it. My re-write was initially just intended for use in-company, so that's my excuse 😊 . No actually, this is: I'm sorry.
Anyways, i hope you can find some use for this update, and that there aren't that many bugs inside. Of course, i haven't tested the code at all; i just pushed it into production and it seemed to work. Then i edited the code some more. Then i created this pull request. Oh dear. What could possibly go wrong?
~rL