Fix JRuby concurrency races in browser OAuth and auth storage#123
Merged
Fix JRuby concurrency races in browser OAuth and auth storage#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes JRuby concurrency races reported in CI for
BrowserOAuthProvider, and adds a broader JRuby hardening pass for auth storage.Issues Addressed
ConcurrencyErrorfrom logger doubles being touched from callback and main auth threads.MemoryStorageused shared Hashes without a mutex, which is risky under JRuby concurrent access.Changes
1) Browser OAuth callback-thread log isolation
BrowserOAuthProvidernow isolates callback-worker logging from the caller logger:NullLoggerfor callback-thread internals (HttpServer,CallbackHandler, and callback worker error path).SynchronizedLogger.2) Thread-safe
MemoryStorage3) Concurrency regression coverage
MemoryStoragespec that performs concurrent reads/writes and asserts no raised errors.Validation
RuboCop
bundle exec rake rubocop✅MRI
bundle exec rake spec✅ (1843 examples, 0 failures)JRuby (Java 21)
RBENV_VERSION=jruby-10.0.2.0 bundle exec rake spec✅ (1843 examples, 0 failures)spec/ruby_llm/mcp/auth/browser_oauth_provider_spec.rb:876spec/ruby_llm/mcp/auth/browser_oauth_provider_spec.rb:974Notes
EADDRINUSEon fixed test ports). Final validation above was run sequentially.