Skip to content

Fix collapsing stack frames loop in error-overlay #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukaw3d wants to merge 1 commit into
base: v2
Choose a base branch
from
+8 −8
Open

Fix collapsing stack frames loop in error-overlay #10180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/utils/error-overlay/src/components/Collapsible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

/* @flow */
import {useState} from 'preact/hooks';
import {useRef} from 'preact/hooks';
import {theme} from '../styles';

const _collapsibleStyle = {
Expand Down Expand Up @@ -40,15 +40,12 @@ type CollapsiblePropsType = {|
|};

function Collapsible(props: CollapsiblePropsType): React$Element<'details'> {
const [collapsed, setCollapsed] = useState(true);

const toggleCollapsed = () => {
setCollapsed(!collapsed);
};
const ref = useRef(null);
const collapsed = ref.current?.open;

const count = props.children.length;
return (
<details open={!collapsed} onToggle={toggleCollapsed}>
<details ref={ref}>
<summary
style={collapsed ? collapsibleCollapsedStyle : collapsibleExpandedStyle}
>
Expand All @@ -58,7 +55,10 @@ function Collapsible(props: CollapsiblePropsType): React$Element<'details'> {
</summary>
<div>
{props.children}
<button onClick={toggleCollapsed} style={collapsibleExpandedStyle}>
<button
onClick={() => ref.current?.removeAttribute('open')}
style={collapsibleExpandedStyle}
>
{`▲ ${count} stack frames were expanded.`}
</button>
</div>
Expand Down
Loading