fix(user): make first/last name optional and hide empty name in profile#344
Open
hariomtiwari-work wants to merge 1 commit intoparalus:mainfrom
Open
fix(user): make first/last name optional and hide empty name in profile#344hariomtiwari-work wants to merge 1 commit intoparalus:mainfrom
hariomtiwari-work wants to merge 1 commit intoparalus:mainfrom
Conversation
Signed-off-by: hariomtiwari-work <hariom.tiwari@infracloud.io>
ebe1347 to
a4462a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Changes
Removed
requiredvalidation and asterisk (*) from First Name and Last Name fields:Fixed profile display issue:
undefined undefinedSteps to Reproduce (Before Fix)
undefined undefineddisplayedAfter Fix
Testing
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.mdnpm run format(if applicable)CHANGELOG.md