BUG: fix np.isnan raising TypeError on pyarrow dtypes (GH#62506)#65041
Draft
jbrockmendel wants to merge 3 commits intopandas-dev:mainfrom
Draft
BUG: fix np.isnan raising TypeError on pyarrow dtypes (GH#62506)#65041jbrockmendel wants to merge 3 commits intopandas-dev:mainfrom
jbrockmendel wants to merge 3 commits intopandas-dev:mainfrom
Conversation
…h_nan_and_na (pandas-dev#62506) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
jorisvandenbossche
requested changes
Apr 3, 2026
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
As mentioned on the issue, it is not just an issue with np.isnan, but with most numeric ufuncs. So I think we should solve this more generally
Member
Author
Will give it a try. |
…guish_nan_and_na (pandas-dev#62506) When distinguish_nan_and_na is True, the default ufunc path converts pyarrow arrays to object-dtype numpy arrays, which most ufuncs can't handle. Fix by converting with na_value=np.nan (producing float arrays) and re-masking NA positions in the result. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…v#62506) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
future.distinguish_nan_and_naisTrue,np.isnanon pyarrow-backed Series/Index raisesTypeErrorbecause the default ufunc path converts to an object-dtype numpy arraynp.isnaninArrowExtensionArray.__array_ufunc__and usepc.is_nanfor numeric pyarrow types, which correctly identifies NaN and propagates NAcloses #62506
Test plan
test_np_isnan_pyarrowcovering bothusing_nan_is_naparametrizationstest_arrow.pysuite passes🤖 Generated with Claude Code