BUG: fix FloatingArray.astype(str) crash with distinguish_nan_and_na=True#65038
Draft
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Draft
BUG: fix FloatingArray.astype(str) crash with distinguish_nan_and_na=True#65038jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
…True (pandas-dev#61617) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Does this also fix #64578? |
Member
Author
|
i dont think so, no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
future.distinguish_nan_and_na=True,FloatingArray.astype(str)(and by extensionto_csv) crashed withArrowTypeErrorbecauseensure_string_arrayleft unmasked NaN values asnp.nanfloat objects, which PyArrow rejects at unmasked positions.skipna=Falsetoensure_string_arrayinArrowStringArray._from_sequenceso NaN values are converted to the string"nan"rather than left as float objects.closes #61617
Test plan
test_astype_masked_float_with_nan_to_string— verifiesFloatingArray.astype("string")with bothusing_nan_is_namodestest_to_csv_float_ea_nan_distinguish— verifiesto_csvon a Float64 column containing bothnp.nanandpd.NA🤖 Generated with Claude Code