BUG: Series.searchsorted raises TypeError for incompatible value dtypes#65015
Draft
jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
Draft
BUG: Series.searchsorted raises TypeError for incompatible value dtypes#65015jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
jbrockmendel
force-pushed
the
bug-searchsorted
branch
from
9c89883 to
cdd0637
Compare
Remove the duplicate searchsorted definition that called super() (which goes through _validate_setitem_value, too strict for searchsorted). Add validate_searchsorted_value to the existing method that correctly bypasses _validate_setitem_value by delegating to numpy directly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Series[numeric].searchsortedwith incompatible value types (e.g.timedelta64,datetime64,str,Timestamp,Timedelta,Period,NaT) previously returned silently wrong results or raised confusing internal numpy errors.validate_searchsorted_valueinalgorithms.pyand call it from four code paths:algorithms.searchsorted(numpy-backed Series/Index),NumpyExtensionArray.searchsorted,BaseMaskedArray.searchsorted, andArrowExtensionArray.searchsorted.Test plan
🤖 Generated with Claude Code