Fixes: #491: correct add_changelog_entry(): Incorrect evr expansion #492
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jessp01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the add_changelog_entry function within the specfile library. Previously, the Epoch-Version-Release (EVR) string was not being expanded correctly, leading to malformed changelog entries. The changes ensure that the EVR is now accurately constructed, improving the reliability and correctness of changelog generation.
Highlights
- Fix EVR Expansion: The
add_changelog_entryfunction now correctly constructs the Epoch-Version-Release (EVR) string by directly usingself.expanded_epoch,self.expanded_version, andself.expanded_releaseinstead of relying on a genericself.expandmethod. This resolves an issue where EVR was being expanded incorrectly, as reported in issue #491.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to fix an incorrect EVR expansion in add_changelog_entry(). While the new method of constructing the EVR string is correct for the default case, the change introduces a critical regression by unconditionally overwriting the evr parameter. This means that if a user provides a custom evr, it will be ignored. My review includes a suggestion to fix this regression by applying the new logic only when the default EVR is being used, and preserving the previous behavior for user-provided evr values.
|
Build failed. ✔️ pre-commit SUCCESS in 1m 59s |
|
Build failed. ✔️ pre-commit SUCCESS in 1m 56s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 11s |
nforro
left a comment
nforro
left a comment
There was a problem hiding this comment.
Thanks. I wonder if we shouldn't disable using macros in evr at all, considering this issue (however rare).
|
Could you please rebase and squash the commits into one? |
|
Also, you need to use |
jessp01
changed the title
|
Build failed. ✔️ pre-commit SUCCESS in 1m 59s |
jessp01
force-pushed
the
better-evr-detection
branch
from
e3e7e01 to
37eedcc
Compare
|
Build failed. ✔️ pre-commit SUCCESS in 1m 57s |
|
Build failed. ❌ pre-commit FAILURE in 1m 56s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 54s |
add_changelog_entry(): Incorrect evr expansion Use the tags() context manager directly for better performance Co-authored-by: Nikola Forró <[email protected]>
jessp01
force-pushed
the
better-evr-detection
branch
from
f2306bb to
05acf46
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 56s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 58s |
softwarefactory-project-zuul
bot
merged commit 87d0521
into
packit:main
3 participants
Address #491: add_changelog_entry(): Incorrect evr expansion