feat: implement naming-convention rule

[neo773]

fixes #186

[camc314]

this test structure looks quite different to the original rule - this makes it hard to review, and tricky to tell if we have complete test coverage with the original rule.

Do you mind porting the tests exactly?

Thanks

[neo773]

Hi,

The ESLint test suite had a dynamic generated test suite via their helper createTestCases
https://github.com/typescript-eslint/typescript-eslint/blob/68a074fb61a10c3627f09678859fb4d42a3b88f5/packages/eslint-plugin/tests/rules/naming-convention/cases/createTestCases.ts#L87

For this I'm not sure what the right approach would be for tsgolint

As for the static tests I think I ported them all, will double check and get back to you.

[camc314]

I see, let me think about it a bit more

[Limerio]

What's your thoughts then? Is it good? (this is just a reminder for you :) ) @camc314

[kalvenschraut]

tsgolint/internal/rules/prefer_optional_chain/prefer_optional_chain_test.go

Line 3956 in 4a09482

invalidCases = append(invalidCases, GenerateBaseCases(BaseCaseOptions{Operator: "&&"})...)

is how I chose to handle the dynamic tests for prefer optional chaining if that direction is more preferred.

[jordan-cutler]

Thank you for addressing this!

[yqazi27]

Are there any updates on this rule?

[camc314]

note to selff: we shuoldn't be exposing stuff like this