-
-
Notifications
You must be signed in to change notification settings - Fork 821
test(linter/plugins): conformance tester support parsers as named exports #19224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(linter/plugins): conformance tester support parsers as named exports #19224
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support to the oxlint conformance runner for parsers that are exported as named exports (not only default/module exports), and updates the E18E conformance group to use typescript-eslint’s parser export accordingly.
Changes:
- Extend
ParserDetailswith optionalpropNameto select a named export from a required module. - Update parser loading logic to pick
module[propName]when provided. - Simplify E18E conformance setup by using
require("typescript-eslint").parserand registering that parser via the newpropNamesupport.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxlint/conformance/src/index.ts | Adds propName to parser metadata and uses it during parser module loading. |
| apps/oxlint/conformance/src/groups/e18e.ts | Switches E18E to use the typescript-eslint package’s named parser export. |
| Cargo.lock | Bumps internal crate versions referenced by the workspace. |
b2fc2d3 to
957bdba
Compare
188171e to
5e42138
Compare
Merge activity
|
…orts (#19224) Refactor of conformance tests. Sometimes a custom parser is a named export of a module, not the default export. Support this case in the conformance runner, and simplify the E18E conformance tests setup by using it.
957bdba to
3d96f6a
Compare
5e42138 to
65d55f3
Compare

Refactor of conformance tests.
Sometimes a custom parser is a named export of a module, not the default export. Support this case in the conformance runner, and simplify the E18E conformance tests setup by using it.