Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 10, 2026

Refactor of conformance tests.

Sometimes a custom parser is a named export of a module, not the default export. Support this case in the conformance runner, and simplify the E18E conformance tests setup by using it.

Copy link
Member Author

overlookmotel commented Feb 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Feb 10, 2026
@overlookmotel overlookmotel marked this pull request as ready for review February 10, 2026 15:52
Copilot AI review requested due to automatic review settings February 10, 2026 15:53
@overlookmotel overlookmotel self-assigned this Feb 10, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing om/02-10-test_linter_plugins_conformance_tester_support_parsers_as_named_exports (f6decbf) with main (3e0e5ba)1

Summary

✅ 43 untouched benchmarks
⏩ 7 skipped benchmarks2

Footnotes

  1. No successful run was found on om/02-10-test_linter_plugins_shorten_conformance_tester_code (b2fc2d3) during the generation of this report, so main (3e0e5ba) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support to the oxlint conformance runner for parsers that are exported as named exports (not only default/module exports), and updates the E18E conformance group to use typescript-eslint’s parser export accordingly.

Changes:

  • Extend ParserDetails with optional propName to select a named export from a required module.
  • Update parser loading logic to pick module[propName] when provided.
  • Simplify E18E conformance setup by using require("typescript-eslint").parser and registering that parser via the new propName support.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
apps/oxlint/conformance/src/index.ts Adds propName to parser metadata and uses it during parser module loading.
apps/oxlint/conformance/src/groups/e18e.ts Switches E18E to use the typescript-eslint package’s named parser export.
Cargo.lock Bumps internal crate versions referenced by the workspace.

@overlookmotel overlookmotel force-pushed the om/02-10-test_linter_plugins_shorten_conformance_tester_code branch from b2fc2d3 to 957bdba Compare February 10, 2026 16:52
@overlookmotel overlookmotel force-pushed the om/02-10-test_linter_plugins_conformance_tester_support_parsers_as_named_exports branch 2 times, most recently from 188171e to 5e42138 Compare February 10, 2026 17:18
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 10, 2026

Merge activity

…orts (#19224)

Refactor of conformance tests.

Sometimes a custom parser is a named export of a module, not the default export. Support this case in the conformance runner, and simplify the E18E conformance tests setup by using it.
@graphite-app graphite-app bot force-pushed the om/02-10-test_linter_plugins_shorten_conformance_tester_code branch from 957bdba to 3d96f6a Compare February 10, 2026 17:44
@graphite-app graphite-app bot force-pushed the om/02-10-test_linter_plugins_conformance_tester_support_parsers_as_named_exports branch from 5e42138 to 65d55f3 Compare February 10, 2026 17:44
Base automatically changed from om/02-10-test_linter_plugins_shorten_conformance_tester_code to main February 10, 2026 17:50
@graphite-app graphite-app bot merged commit 65d55f3 into main Feb 10, 2026
20 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 10, 2026
@graphite-app graphite-app bot deleted the om/02-10-test_linter_plugins_conformance_tester_support_parsers_as_named_exports branch February 10, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant