feat: Add SemanticIdsRunner for symbol/reference ID validation #127
+102
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camc314
force-pushed
the
c/11-19-feat_add_semanticidsrunner_for_symbol_reference_id_validation
branch
from
8b56def to
903951e
Compare
Member
|
Yes, it isn't worth doing in a separate job. However, we can move this check to a job that requires building semantics, e.g., a transformer; you can run the check after semantic data has been built. I think it does the same thing as you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
your choice boshen if we merge this, it was kind of as an outcome of the few panics we recieved because symbol/ref IDs weren't set, so this felt like a good thing to check in CI. But since this code doesn't change much it might not be worth adding a job for it