Test against connection_pool 2.x too#139
Conversation
|
Hey, I’m feeling that adding a dependency to test another dependency is too much overhead. I think that the way you implemented everything is backwards compatible, so is it necessary to test against ~> 2? If the concern is to keep apnotic from breaking compatibility with 2 in the future, is there a simpler test possible like ensuring splatted args are always passed to Thanks again for your work on this! |
No idea how to test like this |
|
What do you think about this PR if I removed the extra dependency |
|
Yeah, if it can be done without the dependency that would be great. Thanks! |
fa11683 to
0e9058b
Compare
0e9058b to
879cbaf
Compare
|
Updated |
|
Hello? |
|
Sorry for the delay. Thank you! |
My previous PR #138 allows connection_pool 2.x but did not test against it (I tested it locally with this but forgot to add
Not new release needed just modification to testing
Also updated the
sizein test case to be sure (since using default value isn't a good test