fix: rename oscal --out flag to --output for consistency#496
Merged
eddie-knight merged 1 commit intoossf:mainfrom Apr 9, 2026
Merged
fix: rename oscal --out flag to --output for consistency#496eddie-knight merged 1 commit intoossf:mainfrom
oscal --out flag to --output for consistency#496eddie-knight merged 1 commit intoossf:mainfrom
Conversation
Signed-off-by: liketosweep <[email protected]>
9de2ad8 to
7539c8a
Compare
funnelfiasco
approved these changes
Apr 9, 2026
Contributor
funnelfiasco
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
eddie-knight
approved these changes
Apr 9, 2026
Contributor
Author
|
Thanks for the quick reviews and for merging! Glad I could help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: rename
oscalcommand's--outflag to--outputProblem
The
oscalcommand uses--outas its output file flag, while thecompilecommanduses
--outputfor the same purpose. This inconsistency forces users to rememberdifferent flag names for the same operation depending on which command they are using.
Root Cause
The
oscalandcompilecommands were implemented without a shared flag namingconvention, causing the same logical argument — the output file path — to be named
differently across the two commands.
Fix
cmd/oscal.gofrom"out"to"output"in theStringVarPcall-oremains unchanged, preserving backward compatibilityREADME.mdto reflect the new--outputflag--outflagResult
go buildpasses with no errors--outputgenerates valid OSCAL JSON output successfully--outcorrectly returnsERROR: unknown flag: --outconfirming removal-oshorthand continues to work as expectedFixes #282