Fix: Update package.json version to match git tag v3.53.0#93
Closed
jeandoBet wants to merge 5 commits intooss-serverless:mainfrom
Closed
Fix: Update package.json version to match git tag v3.53.0#93jeandoBet wants to merge 5 commits intooss-serverless:mainfrom
jeandoBet wants to merge 5 commits intooss-serverless:mainfrom
Conversation
Contributor
GrahamCampbell
left a comment
There was a problem hiding this comment.
I'd rather just delete the version out of here if we can.
Contributor
|
+1 I don't want to maintain it |
Author
|
It seems to be a mandatory field for npm. |
Contributor
|
Let's find another approach because we don't want to manually update this field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current
package.jsoncontains version3.40.1while the git repository has tagv3.53.0. This creates inconsistency when installing via npm from git reference:Despite specifying tag
v3.53.0, npm installs version3.40.1because it reads the version frompackage.json, not from the git tag.Solution
Update the
versionfield inpackage.jsonfrom3.40.1to3.53.0to match the git tag.Impact
Verification
After this change,
npx serverless --versionwill correctly display:Type of change