fix(ort-project-file): Properly set the projet's vcs / vcsProcessed#11590
Open
fix(ort-project-file): Properly set the projet's vcs / vcsProcessed#11590
vcs / vcsProcessed#11590Conversation
fviernau
force-pushed
the
ort-project-file-fix-project-vcs
branch
from
4fffae6 to
4e55ee3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11590 +/- ##
=========================================
Coverage 58.40% 58.40%
Complexity 1758 1758
=========================================
Files 355 355
Lines 13219 13219
Branches 1314 1314
=========================================
Hits 7721 7721
Misses 5008 5008
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ), | ||
| vcs = processProjectVcs(definitionFile.parentFile), | ||
| vcs = VcsInfo.EMPTY, | ||
| vcsProcessed = processProjectVcs(definitionFile.parentFile), |
Member
There was a problem hiding this comment.
Should this use the homepage URL as fallback like in other package managers?
Make the implementation consistent with other package managers in the code base. Note that the model does not have a property for the VCS info of the project, so `Project.vcs` should remain empty. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
ort-project-file-fix-project-vcs
branch
from
4e55ee3 to
0a7c680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the implementation consistent with other package managers in the code base. Note that the model does not have a property for the VCS info of the project, so
Project.vcsshould remain empty.