fix(gradle): Handle changing collections in init script#11589
Draft
Juli0q wants to merge 1 commit intooss-review-toolkit:mainfrom
Draft
fix(gradle): Handle changing collections in init script#11589Juli0q wants to merge 1 commit intooss-review-toolkit:mainfrom
Juli0q wants to merge 1 commit intooss-review-toolkit:mainfrom
Conversation
Juli0q
force-pushed
the
fix/gradle-concurrent-modification
branch
from
8494857 to
81a59c2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11589 +/- ##
=========================================
Coverage 58.40% 58.40%
Complexity 1758 1758
=========================================
Files 355 355
Lines 13219 13219
Branches 1314 1314
=========================================
Hits 7721 7721
Misses 5008 5008
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fviernau
reviewed
Mar 20, 2026
Process configurations and repositories until no new entries are found instead of iterating live collections directly or taking a single snapshot. This avoids concurrent modification issues while still picking up configurations and repositories that are added during resolution. Signed-off-by: Julian Olderdissen <[email protected]>
Juli0q
force-pushed
the
fix/gradle-concurrent-modification
branch
from
81a59c2 to
64ff236
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import org.ossreviewtoolkit.utils.test.getAssetFile | ||
| import org.ossreviewtoolkit.utils.test.matchExpectedResult | ||
|
|
||
| class GradleConcurrentModificationFunTest : FunSpec({ |
Check warning
Code scanning / QDJVM
Unused symbol Warning
| import org.ossreviewtoolkit.utils.test.getAssetFile | ||
| import org.ossreviewtoolkit.utils.test.matchExpectedResult | ||
|
|
||
| class GradleLateRepositoryFunTest : FunSpec({ |
Check warning
Code scanning / QDJVM
Unused symbol Warning
Juli0q
changed the title
Member
|
Just wondering @Juli0q: Does it really make sense to address this in the "legacy" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process configurations and repositories until no new entries are found instead of iterating live collections directly or taking a single snapshot. This avoids concurrent modification issues while still picking up configurations and repositories that are added during resolution.