Backports from master#4184
Merged
vicentebolea merged 12 commits intoornladios:release_210from May 29, 2024
Merged
Conversation
pugixml,cmake: fix linkage when pugixml is external
Add a new external mode for opening files, ReadFlattenSteps. This is like ReadRandomAccess (in that it reads all metadata immediately and you can't use BeginStep), but it causes *all* the timesteps in the file to be Flattened into a single step, as if each Put() has been done in that step.
Adding hooks to gather performance for derived variables
* Add API to reset memory selection
Code extracted from: https://github.com/GTkorvo/EVPath.git at commit 45471c87f14c735bb4a3f92477f3a04b0a06b18a (master).
vicentebolea
force-pushed
the
backports-from-master
branch
from
50c0c70 to
7e8248e
Compare
Member
ornladios#4160) Remove special ReadFlattenSteps Mode, switch to control by writer-side FlattenSteps parameter
eisenhauer
reviewed
May 28, 2024
Contributor
Author
|
@eisenhauer it appears that we are not ABI compatible anymore at least since #4144. Does it make sense to revert it? releasing a non abi compatible patch release might result in trouble for conda users (or other distros). |
Contributor
Author
|
No worries, I was able to come up with a ABI compatible fix. |
Member
|
Excellent... |
eisenhauer
previously approved these changes
May 28, 2024
Member
eisenhauer
left a comment
eisenhauer
left a comment
There was a problem hiding this comment.
I don't see further problems...
vicentebolea
force-pushed
the
backports-from-master
branch
from
24fb83f to
e77056e
Compare
eisenhauer
approved these changes
May 28, 2024
Contributor
Author
|
Passing 😄 |
Member
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported Pull Requests
#4181 EVPath Upstream eisenhauer:EVup about 19 hours ago
#4169 Add API call to reset memory selection franzpoeschel:reset-memory-selection about 7 days ago
#4166 Typo in documentation anagainaru:typo-build-doc about 11 days ago
#4161 Adding hooks to gather performance for... anagainaru:derived-performance about 17 days ago
#4153 Minor docs tweaks eisenhauer:DocsUpdate about 1 month ago
#4147 ReadModeFlatten eisenhauer:Flatten about 1 month ago
#4142 pugixml,cmake: fix linkage when pugixm... vicentebolea:fix-pugixml-dep about 1 month ago
#4138 Fixes for FreeBSD, including upstream eisenhauer:FreeBSD about 1 month ago
#4185 Kill outdated reference to bindings.Mode.ReadFlattenSteps