Skip to content

Conversation

@Bijnagte
Copy link

Description

I ran into an issue while trying to use the client against our internal registry since it uses a different (but allowed) token response field. As I was debugging I also noticed that the repeated calls to the auth store can actually reduce performance because it delegates to the binary locally multiple times so I just added a fix for that as well.

Testing done

I did not add tests at this point because the current behavior is not tested and I would prefer to make sure I can get the library to work before investing a lot of time in setting up complex testing using wiremock or refactoring significantly.

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@Bijnagte Bijnagte requested a review from jonesbusy as a code owner January 22, 2026 16:44
@jonesbusy
Copy link
Collaborator

Thanks! Can you apply spotless formatting? It's currently failing the build

@jonesbusy jonesbusy added the bug Something isn't working label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants