Support access_token during login and reduce calls to auth store #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into an issue while trying to use the client against our internal registry since it uses a different (but allowed) token response field. As I was debugging I also noticed that the repeated calls to the auth store can actually reduce performance because it delegates to the binary locally multiple times so I just added a fix for that as well.
Testing done
I did not add tests at this point because the current behavior is not tested and I would prefer to make sure I can get the library to work before investing a lot of time in setting up complex testing using wiremock or refactoring significantly.
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR