security/acme-client: Fix certificate grid button handlers not working #5144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bootgrid
Fixed two issues with the certificate grid action buttons not working
correctly with the new UIBootgrid/Tabulator system in OPNsense 25.7.x:
1. Buttons not firing (no popup appearing):
- Added e.stopPropagation() and e.preventDefault() to all command
handlers to prevent Tabulator's row selection from intercepting
button clicks
- Changed custom command handlers (toggle, sign, revoke, removekey,
automation, import) to use document-level event delegation with
namespaced events
2. Multiple clicks required to close dialogs:
- Moved custom command handlers OUTSIDE the loaded.rs.jquery.bootgrid
callback to prevent duplicate handlers being attached on each grid
reload
- Used .off() before .on() with namespaced events (e.g.,
"click.acme.import") to ensure only one handler exists
- Added .off('click').on() pattern for handlers that must remain
inside the callback (edit, copy, delete, add, deleteSelected)
The loaded.rs.jquery.bootgrid event fires on every grid reload, so
handlers attached inside it would stack up, causing multiple dialogs
to open on a single click.
Fixes opnsense#5123
Co-Authored-By: Claude Opus 4.5 <[email protected]>
NormB
force-pushed
the
bugfix/acme-revoke-button
branch
from
e39b335 to
c36e0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes certificate grid action buttons (Issue/Renew, Re-Import, Run Automations, Revoke, Reset) not working correctly with the new UIBootgrid/Tabulator system in OPNsense 25.7.x.
Problems Fixed
1. Buttons not firing (no popup appearing)
e.stopPropagation()ande.preventDefault()to all command handlers2. Multiple clicks required to close dialogs
loaded.rs.jquery.bootgridevent fires on every grid reload.off()before.on()to ensure single handlerChanges
click.acme.toggle, etc.)e.stopPropagation()ande.preventDefault()to prevent Tabulator interference.off('click').on()pattern for handlers that must remain inside the callbackTesting
Fixes #5123
Co-Authored-By: Claude Opus 4.5 [email protected]