Move storage of HealthReports into dedicated model#23007
Open
NobodysNightmare wants to merge 1 commit intodevfrom
Open
Move storage of HealthReports into dedicated model#23007NobodysNightmare wants to merge 1 commit intodevfrom
NobodysNightmare wants to merge 1 commit intodevfrom
Conversation
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
NobodysNightmare
force-pushed
the
core-health-reports
branch
from
d09ae78 to
31c4668
Compare
So far they have only been stored in the Rails cache, making them pretty volatile. They are now properly stored in the database, theoretically allowing to also retrieve older health check results and compare them to newer ones. Translation responsibilities have been moved into respective components, that are rendering the results. This is part of a refactoring that moves health reports and their components out of the storages module into the core, allowing them to be reused by different modules.
NobodysNightmare
force-pushed
the
core-health-reports
branch
from
31c4668 to
d31dfeb
Compare
NobodysNightmare
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far they have only been stored in the Rails cache, making them pretty volatile. They are now properly stored in the database, theoretically allowing to also retrieve older health check results and compare them to newer ones.
Translation responsibilities have been moved into respective components, that are rendering the results.
This is part of a refactoring that moves health reports and their components out of the storages module into the core, allowing them to be reused by different modules.
Ticket
https://community.openproject.org/wp/72978