include filter working with portfolios and programs#22998
Open
ulferts wants to merge 1 commit intorelease/17.4from
Open
include filter working with portfolios and programs#22998ulferts wants to merge 1 commit intorelease/17.4from
ulferts wants to merge 1 commit intorelease/17.4from
Conversation
ulferts
force-pushed
the
bug/74536-errors-with-include-project-work-package-list-filter-with-a-portfolio
branch
from
b2e1997 to
bd4761e
Compare
ulferts
force-pushed
the
bug/74536-errors-with-include-project-work-package-list-filter-with-a-portfolio
branch
from
bd4761e to
222639f
Compare
ulferts
commented
Apr 30, 2026
| return ((resource instanceof HalResource) ? resource.href : resource) === this.currentProject.apiv3Path; | ||
| const href = (resource instanceof HalResource) ? resource.href : resource; | ||
| const hrefParts = href?.split('/'); | ||
| return hrefParts?.[hrefParts.length - 1] === currentProjectId; |
Contributor
Author
There was a problem hiding this comment.
There is the option of moving this into the CurrentProjectService so that other callers can profit from it. Currently though, this was the only place I could find.
The other use case within this PR is different in that it actually needs the api href rather than just knowing if it is the current workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/74536
What are you trying to accomplish?
Fix include projects with when portfolios and programs are involved
The fixes in here try to strike a balance between fixing the bugs with limited effort and avoiding to worsen code quality. But the tendency here is minimize the effort meaning code quality is not the best in this PR.
Ideally:
work-package-filter-valueswould be avoided.Merge checklist