[#74399] No max limit for password length #22988
Merged
mrmir merged 3 commits intorelease/17.4from Apr 30, 2026
Merged
Conversation
dfriquet
reviewed
Apr 30, 2026
Comment on lines
+94
to
+100
| validates :value, | ||
| numericality: { | ||
| only_integer: true, | ||
| greater_than_or_equal_to: 1, | ||
| less_than_or_equal_to: 128, | ||
| if: ->(setting) { setting.name == "password_min_length" } | ||
| } |
Contributor
There was a problem hiding this comment.
I’m torn, honestly, between your really simple ad-hoc solution, and the magic numbers duplication. A more generic validation retrieving allowed values in the definition would be great in this regard.
I’m wondering if it’s worth the extra mile.
Contributor
Author
There was a problem hiding this comment.
Good call, I tried to do it via a constant now. Does that work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/74399
Merge checklist