golang: add option to skip building bootstrap #28476
Merged
+70
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new configuration option - GOLANG_BUILD_BOOTSTRAP - that defaults to enabled: - When enabled, build the local bootstrap instead of using an external one for host Go. If GOLANG_EXTERNAL_BOOTSTRAP_ROOT is set, skip the initial 1.4 step. - When disabled, let Go auto-detect the toolchain or use the toolchain specified in GOLANG_EXTERNAL_BOOTSTRAP_ROOT to skip building the bootstrap and build host Go using that toolchain directly. Configured toolchain must be compatible with the current version of Go. HOST_BUILD_DEPENDS cannot be conditional, so some Makefile juggling is needed. Put menu config under bootstrap only. Remove unnecessary package-related flags from host-only bootstrap. Signed-off-by: George Sapkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: me
Description:
Introduce a new configuration option -
GOLANG_BUILD_BOOTSTRAP- that defaults to enabled:When enabled, build the local bootstrap instead of using an external one for host Go. If
GOLANG_EXTERNAL_BOOTSTRAP_ROOTis set, skip the initial 1.4 step.When disabled, let Go auto-detect the toolchain or use the toolchain specified in
GOLANG_EXTERNAL_BOOTSTRAP_ROOTto skip building the bootstrap and build host Go using that toolchain directly. Configured toolchain must be compatible with the current version of Go.HOST_BUILD_DEPENDScannot be conditional, so some Makefile juggling is needed.Put menu config under bootstrap only.
Remove unnecessary package-related flags from host-only bootstrap.
🧪 Run Testing Details
Tested various permutations of the aforementioned configuration options.
Tested building and running AdGuard Home, CoreDNS, Syncthing and Tailscale.
✅ Formalities