Fix misleading comments in SHA-crypt and derived code

[dchidindu5]

Cross checked and fixed the following modules for duplicate comments that does not reflect the action of the code.

./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sm3crypt_fmt_plug.c:		/* For every character in the password add the entire password. */
./sha512crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./ztex/fpga-sha512crypt/sha512crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./ztex/fpga-sha256crypt/sha256crypt/cpu/program.vh:	// "For every character in the password add the entire password."
./sha256crypt_fmt_plug.c:			/* For every character in the password add the entire password.  */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12256hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost12512hash_fmt_plug.c:		/* For every character in the password add the entire password.  */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */
./gost94hash_fmt_plug.c:		/* For every character in the password add the entire password. */

[solardiz]

Thanks.

The comments changes themselves look good to me. I see the wording resembles what's already used in these files:

./sha512crypt_fmt_plug.c:			/* repeat the following 16+A[0] times, where A[0] represents the
./sha256crypt_fmt_plug.c:			/* repeat the following 16+A[0] times, where A[0] represents the
./gost12512hash_fmt_plug.c:		/* repeast the following 16+A[0] times, where A[0] represents the

While at it, I also notice the typo in repeast there. You may fix this as well.

However, the commits here need to be revised. For the commit message, I suggest:

Fix misleading comments in SHA-crypt and derived code

Fixes #5951

There should be no technical/irrelevant history here. No merge commit of bleeding-jumbo into your branch - instead, your branch should have been rebased and force-pushed.

I could take care of this by squash-and-merge this time, but if this whole exercise is to practice for your further contributions then you may want to do it right already for this PR, I guess?

[dchidindu5]

I'd apply the needed changes and also squash the commit. Thanks a lot

…

On Sun, 15 Mar 2026, 12:52 am Solar Designer, ***@***.***> wrote: *solardiz* left a comment (openwall/john#5962) <#5962 (comment)> Thanks. The comments changes themselves look good to me. I see the wording resembles what's already used in these files: ./sha512crypt_fmt_plug.c: /* repeat the following 16+A[0] times, where A[0] represents the ./sha256crypt_fmt_plug.c: /* repeat the following 16+A[0] times, where A[0] represents the ./gost12512hash_fmt_plug.c: /* repeast the following 16+A[0] times, where A[0] represents the While at it, I also notice the typo in repeast there. You may fix this as well. However, the commits here need to be revised. For the commit message, I suggest: Fix misleading comments in SHA-crypt and derived code Fixes #5951 There should be no technical/irrelevant history here. No merge commit of bleeding-jumbo into your branch - instead, your branch should have been rebased and force-pushed. I could take care of this by squash-and-merge this time, but if this whole exercise is to practice for your further contributions then you may want to do it right already for this PR, I guess? — Reply to this email directly, view it on GitHub <#5962 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEPEESZCRAMSQCKWGPAFJ6L4QXWFRAVCNFSM6AAAAACWQ3BMYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRRG4ZDCMBTGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>