Skip to content

Feature/trans pqtl coloc feature#1210

Draft
addramir wants to merge 3 commits intodevfrom
feature/trans-pqtl-coloc-feature
Draft

Feature/trans pqtl coloc feature#1210
addramir wants to merge 3 commits intodevfrom
feature/trans-pqtl-coloc-feature

Conversation

@addramir
Copy link
Contributor

@addramir addramir commented Mar 19, 2026

✨ Context

🛠 What does this PR implement

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g uv run pre-commit run --all-files)?

addramir added 2 commits March 19, 2026 14:30
@addramir
feat: add trans-pQTL colocalisation feature for L2G prediction
817f80a 
This commit introduces a new feature for Locus-to-Gene (L2G) prediction that:

- Extracts and scores colocalizations with trans-pQTLs
- Filters for significant colocalizations (H4 > 0.8)
- Computes maximum colocalisation H4 score per gene in a locus
- Integrates with existing L2G feature matrix and prediction pipeline

New components:
- TransPQtlColocH4MaximumFeature class in colocalisation.py
- common_trans_pqtl_colocalisation_feature_logic() helper function
- Feature registration in FeatureFactory
- Comprehensive test suite with 80%+ code coverage

The feature identifies genetic interactions between disease-associated loci and
trans-acting protein QTL effects, enhancing gene prioritization in disease mapping.
@addramir
fix: test
dd922b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Dataset Method size-L Step

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@addramir