-
Notifications
You must be signed in to change notification settings - Fork 144
[cifmw_cephadm] fix: drop FQCN for ci_script #3621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add [cifmw_cephadm] to the beginning of your commit title and add description and a signed-off-by line to the commit body to pass the two failing checks
a416feb to
438e64a
Compare
|
The commit message body check is still failing, as the body requires a minimum amount of characters (not including the signed-off-by line). I think the description of this pr does a good job describing what this patch is doing, so feel free to include the lines about 'The zuul executor...' and 'This patch reverts...' in the commit body. |
The Zuul executor runs a restricted Ansible environment where the 'cifmw' collection is not formally installed. It relies on finding plugins via relative paths rather than collection namespaces. Consequently, the FQCN 'cifmw.general.ci_script' cannot be resolved. This patch reverts the module call to the short name 'ci_script' to ensure the plugin is correctly located. JIRA: OSPCIX-1169 Link: https://issues.redhat.com/browse/OSPCIX-1169 Signed-off-by: Oleg Belolipetskii <[email protected]>
438e64a to
08b8503
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1dec2f811c5949f4a44bffdbef0b8236 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 56s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fb765232fafa4c9e917cc4efe3a717be ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 55s |
[cifmw_cephadm] fix: drop FQCN for ci_script
The Zuul executor runs a restricted Ansible environment where the 'cifmw' collection is not formally installed. It relies on finding plugins via relative paths rather than collection namespaces. Consequently, the FQCN 'cifmw.general.ci_script' cannot be resolved.
This patch reverts the module call to the short name 'ci_script' to ensure the plugin is correctly located.
JIRA: OSPCIX-1169
Link: https://issues.redhat.com/browse/OSPCIX-1169
Signed-off-by: Oleg Belolipetskii [email protected]