Skip to content

OCPBUGS-83402: Bump oc request-timeout to deflake tests#31008

Open
xueqzhan wants to merge 1 commit intoopenshift:mainfrom
xueqzhan:request-timeout-increase
Open

OCPBUGS-83402: Bump oc request-timeout to deflake tests#31008
xueqzhan wants to merge 1 commit intoopenshift:mainfrom
xueqzhan:request-timeout-increase

Conversation

@xueqzhan
Copy link
Copy Markdown
Contributor

@xueqzhan xueqzhan commented Apr 14, 2026

Summary by CodeRabbit

  • Tests
    • Adjusted test timeout configurations for improved test robustness.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@xueqzhan: This pull request references Jira Issue OCPBUGS-83402, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from deads2k April 14, 2026 12:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 26b5cb38-adb9-4b0f-8d55-b815c9bc333f

📥 Commits

Reviewing files that changed from the base of the PR and between 9df27cd and d8f647c.

📒 Files selected for processing (1)
  • test/extended/cli/timeout.go

Walkthrough

The test file updates request timeout values in CLI timeout tests, changing --request-timeout parameters from 2s to 5s for DeploymentConfig and Deployment query operations. Test assertions and error-handling logic remain unchanged.

Changes

Cohort / File(s) Summary
Test Timeout Values
test/extended/cli/timeout.go
Updated --request-timeout values from 2s to 5s in get dc/testdc and get deployment/testdc test invocations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❓ Inconclusive Unable to execute shell script directly; file path and content cannot be verified without access to repository. Provide the file content or verify the test/extended/cli/timeout.go file exists and contains the necessary verification checks.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'OCPBUGS-83402: Bump oc request-timeout to deflake tests' directly and clearly describes the main change: increasing the request-timeout value in oc commands to reduce test flakiness.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed All Ginkgo test names in the modified file are stable and deterministic with no dynamic information such as timestamps, generated IDs, or pod names.
Test Structure And Quality ✅ Passed Test file demonstrates good structure with single responsibility It blocks, proper BeforeEach/AfterEach setup/cleanup patterns, and appropriate timeout handling via --request-timeout flag increased from 2s to 5s to improve stability.
Microshift Test Compatibility ✅ Passed PR modifies existing tests by updating timeout values from 2s to 5s; does not add new Ginkgo e2e tests, so check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies timeout values in existing tests; no new Ginkgo e2e tests are introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Pull request modifies only test file validating CLI timeout parameters with no deployment manifests, scheduling constraints, or topology-aware scheduling configurations.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies existing tests by adjusting timeout values only; does not add new Ginkgo e2e tests and contains no IPv4 assumptions or external connectivity requirements.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested a review from sjenning April 14, 2026 12:50
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@xueqzhan: This pull request references Jira Issue OCPBUGS-83402, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Summary by CodeRabbit

  • Tests
  • Adjusted test timeout configurations for improved test robustness.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-2of2 d8f647c link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn-fips d8f647c link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn d8f647c link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn d8f647c link true /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 d8f647c link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn-upi d8f647c link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants