Skip to content

add oc-mirror to extensionBinaries#31006

Draft
adolfo-ab wants to merge 1 commit intoopenshift:mainfrom
adolfo-ab:ote-oc-mirror
Draft

add oc-mirror to extensionBinaries#31006
adolfo-ab wants to merge 1 commit intoopenshift:mainfrom
adolfo-ab:ote-oc-mirror

Conversation

@adolfo-ab
Copy link
Copy Markdown

@adolfo-ab adolfo-ab commented Apr 14, 2026

Summary by CodeRabbit

  • Tests
    • Added test infrastructure for extension testing capabilities, expanding the set of test binaries available for validation and verification purposes.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: adc7b91b-e67a-456e-83e7-9e82b0a9c79d

📥 Commits

Reviewing files that changed from the base of the PR and between 9df27cd and 8d1f099.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

A new test binary entry was added to the extension binaries configuration in the test utilities, specifying an image tag and binary path for oc-mirror extension testing without any changes to logic or control flow.

Changes

Cohort / File(s) Summary
Extension Test Binary Configuration
pkg/test/extensions/binary.go
Added a new TestBinary entry to extensionBinaries with image tag "oc-mirror-tests-extension" and binary path "/usr/bin/oc-mirror-test-extension.tar.gz" for extension test operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❓ Inconclusive The PR only adds a configuration entry for oc-mirror-tests-extension binary without providing its source code, making stdout contract compliance verification impossible. Provide access to the oc-mirror-tests-extension binary source code or document verification of OTE stdout contract compliance before merging.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an oc-mirror entry to the extensionBinaries collection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The PR adds a static data structure entry to the extensionBinaries configuration slice. No Ginkgo test declarations with dynamic names are introduced.
Test Structure And Quality ✅ Passed The PR only adds a configuration entry to extensionBinaries slice in a utility module, not Ginkgo test code.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; only a test binary registration entry was added to the extensionBinaries slice.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Pull request only modifies test infrastructure configuration in binary.go, registering a new extension binary. No new Ginkgo e2e tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed Pull request adds test extension binary configuration to test infrastructure variable with no deployment manifests, operators, controllers, or scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests, only registers an external test binary for the testing framework.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adolfo-ab
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

@adolfo-ab: This PR was included in a payload test run from openshift/oc-mirror#1375
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7c82a9e0-37f1-11f1-8f47-552584c66ffc-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@adolfo-ab: This PR was included in a payload test run from openshift/oc-mirror#1375
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3268a3e0-38c4-11f1-8097-e51627f73738-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

@adolfo-ab: This PR was included in a payload test run from openshift/oc-mirror#1375
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dc7638b0-38d9-11f1-8041-6bf03a0e77d4-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant