-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CNV-70941: (Doc) Start a VM console session directly from the tree-view #104298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Vaishali-gif-rh: This pull request references CNV-70941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gouyang - Please let me know if we're good to move ahead with the changes I've made. Thankyou! |
|
@Vaishali-gif-rh: This pull request references CNV-70941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
sjhala-ccs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some initial suggestions. It will be helpful to refer to the actual UI to make sure the step description is accurate.
e7bcae4 to
c17c8c3
Compare
|
@Vaishali-gif-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@Vaishali-gif-rh: This pull request references CNV-70941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick enterprise-4.21 |
|
@sjhala-ccs: new pull request created: #104622 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.21
Issue:
https://issues.redhat.com/browse/CNV-70941
Link to docs preview:
https://104298--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/managing_vms/virt-accessing-vm-consoles.html#virt-connecting-to-vm-console-web_vnc-console
QE review: