DNM: test aws ccm byo sg for NLBs#460
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
/testwith openshift/cloud-provider-aws/main/e2e-aws-ovn-techpreview openshift/cloud-provider-aws#152 openshift/installer#10512 |
|
@mfbonfigli you may need update ote go.mod to your version containing upstream e2e tests |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
WalkthroughThis PR updates the Go toolchain from 1.25.0 to 1.26.0 in ChangesDependency & Toolchain Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
openshift-tests/ccm-aws-tests/go.mod (1)
3-3: Consider updating to Go 1.26.2, the latest stable release.Go 1.26.0 is a valid released version. However, go1.26.2 (released 2026-04-07) is now available and is the current stable version. Updating to the latest patch release would ensure access to recent bug fixes and improvements.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openshift-tests/ccm-aws-tests/go.mod` at line 3, Update the Go toolchain version in the go.mod file by changing the module directive value from "go 1.26.0" to "go 1.26.2": open the go.mod and replace the existing go version token (the "go" directive) so the project uses Go 1.26.2, then run `go mod tidy` or your project's dependency bootstrap to ensure tooling picks up the updated version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@openshift-tests/ccm-aws-tests/go.mod`:
- Around line 16-18: The go.mod currently mixes Kubernetes module versions
(k8s.io/api, k8s.io/apimachinery, k8s.io/client-go at v0.36.0 while
k8s.io/kubernetes remains v1.35.0 and several components are replaced/pinned to
v0.35.0 via replace directives), which can cause resolution and API mismatches;
either confirm this skew is intentional for your tests or make the versions
consistent: to align downward, change k8s.io/api, k8s.io/apimachinery, and
k8s.io/client-go to v0.35.0 to match the replace pins and k8s.io/kubernetes; or
to align upward, bump k8s.io/kubernetes and all replace directives to
v1.36.0/v0.36.0 as appropriate and run go mod tidy to refresh module graph and
verify e2e tests; update any replace directives referencing Kubernetes
components to the chosen consistent version.
---
Nitpick comments:
In `@openshift-tests/ccm-aws-tests/go.mod`:
- Line 3: Update the Go toolchain version in the go.mod file by changing the
module directive value from "go 1.26.0" to "go 1.26.2": open the go.mod and
replace the existing go version token (the "go" directive) so the project uses
Go 1.26.2, then run `go mod tidy` or your project's dependency bootstrap to
ensure tooling picks up the updated version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f5354a3a-29f9-42b8-8e83-8f0e89f77f08
⛔ Files ignored due to path filters (1)
openshift-tests/ccm-aws-tests/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
openshift-tests/ccm-aws-tests/go.mod
|
/testwith openshift/cloud-provider-aws/main/e2e-aws-ovn-techpreview openshift/cloud-provider-aws#152 openshift/installer#10512 |
2 participants
Do not merge
Empty PR just to exercise CI with upstream changes.
Summary by CodeRabbit