Skip to content

OCPBUGS-63080: telco-ran: BMH ignoredifferences siteconfig patch for ignitionConfig annotation#600

Open
abraham2512 wants to merge 1 commit intoopenshift-kni:release-4.20from
abraham2512:patch-ocpbugs-63080
Open

OCPBUGS-63080: telco-ran: BMH ignoredifferences siteconfig patch for ignitionConfig annotation#600
abraham2512 wants to merge 1 commit intoopenshift-kni:release-4.20from
abraham2512:patch-ocpbugs-63080

Conversation

@abraham2512
Copy link
Copy Markdown
Member

This PR includes a patch to ignore differences in ArgoCD for ignition config override in BMH CR. This is needed in siteconfigv1 flow to prevent argo from flagging a diff when assisted service inject certificates to the ignition config override annotation

@openshift-ci openshift-ci bot requested review from imiller0 and yuvalk February 26, 2026 16:51
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abraham2512
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-63080, which is invalid:

  • expected the bug to target the "4.20.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-63080 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR includes a patch to ignore differences in ArgoCD for ignition config override in BMH CR. This is needed in siteconfigv1 flow to prevent argo from flagging a diff when assisted service inject certificates to the ignition config override annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abraham2512
Copy link
Copy Markdown
Member Author

/add-label jira/valid-bug

@abraham2512
Copy link
Copy Markdown
Member Author

/remove-label jira/invalid-bug

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 26, 2026

@abraham2512: The label(s) /remove-label jira/invalid-bug cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/remove-label jira/invalid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abraham2512
Copy link
Copy Markdown
Member Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants