Skip to content

OCPBUGS-72511: Explicitly set the name of BSL#568

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-kni:mainfrom
sudomakeinstall2:OCPBUGS-72511
Mar 3, 2026
Merged

OCPBUGS-72511: Explicitly set the name of BSL#568
openshift-merge-bot[bot] merged 1 commit intoopenshift-kni:mainfrom
sudomakeinstall2:OCPBUGS-72511

Conversation

@sudomakeinstall2
Copy link
Copy Markdown
Contributor

@sudomakeinstall2 sudomakeinstall2 commented Jan 28, 2026

This commit explicitly sets the BackupStorageLocation name in the DataProtectionApplication rather than relying on the default behavior. Additionally, BackupStorageLocation status policy is added to valdiator policy. This change is necessary because the status policy creates an empty BackupStorageLocation, and recent OADP updates no longer allow setting a default value for a BackupStorageLocation after it has already been created.

@openshift-ci openshift-ci bot requested review from fedepaol and sabbir-47 January 28, 2026 17:21
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-72511, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This commit explicitly sets the name of backupstoragelocation in DataProtectionApplication, and no longer rely only on the default behaviour.
Also we make sure the backupstoragelocation status policy has a bigger ztp wave annotation number. This is because the status policy creates an empty backupstoragelocation, and with recent changes in oadp we are not allowed to set the default value for a backupstoragelocation after it has been already created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sudomakeinstall2
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
@jc-rh
Copy link
Copy Markdown
Member

jc-rh commented Feb 26, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
This commit explicitly sets the name of backupstoragelocation in
DataProtectionApplication, and no longer rely only on the default
behaviour.
Also we make sure the backupstoragelocation status policy has
a bigger ztp wave annotation number. This is because the status policy
creates an empty backupstoragelocation, and with recent changes in oadp
we are not allowed to set the default value for a backupstoragelocation
after it has been already created.

Signed-off-by: Saeid Askari <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-72511, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This commit explicitly sets the BackupStorageLocation name in the DataProtectionApplication rather than relying on the default behavior. Additionally, BackupStorageLocation status policy is added to valdiator policy. This change is necessary because the status policy creates an empty BackupStorageLocation, and recent OADP updates no longer allow setting a default value for a BackupStorageLocation after it has already been created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Missxiaoguo
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2026
@irinamihai
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irinamihai, sudomakeinstall2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@sudomakeinstall2
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit acf1f51 into openshift-kni:main Mar 3, 2026
2 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@sudomakeinstall2: Jira Issue OCPBUGS-72511: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-72511 has been moved to the MODIFIED state.

Details

In response to this:

This commit explicitly sets the BackupStorageLocation name in the DataProtectionApplication rather than relying on the default behavior. Additionally, BackupStorageLocation status policy is added to valdiator policy. This change is necessary because the status policy creates an empty BackupStorageLocation, and recent OADP updates no longer allow setting a default value for a BackupStorageLocation after it has already been created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sudomakeinstall2
Copy link
Copy Markdown
Contributor Author

/cherrypick release-4.21

@sudomakeinstall2
Copy link
Copy Markdown
Contributor Author

/cherrypick release-4.20

@openshift-cherrypick-robot
Copy link
Copy Markdown

@sudomakeinstall2: new pull request created: #620

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@sudomakeinstall2: new pull request created: #621

Details

In response to this:

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants