OCPBUGS-62684: Move enable-crun manifests out of optional manifests

[sudomakeinstall2]

According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.

Signed-off-by: Saeid Askari saskari@redhat.com

[openshift-ci-robot]

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-6284, which is invalid:

• expected the bug to be open, but it isn't
• expected the vulnerability to target either version "4.22." or "openshift-4.22.", but it targets "4.13.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Not a Bug) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sudomakeinstall2
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sudomakeinstall2: This pull request references Jira Issue OCPBUGS-62684, which is invalid:

• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

According to RDS enable-crun is not optional. This commit moves them out
of the optional folder.

Signed-off-by: Saeid Askari saskari@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[abraham2512]

/lgtm

[irinamihai]

Why not move the crun extra-manifests under the extra-manifest directory OR rename crun to extra-manifest-crun to make the purpose obvious?

[sudomakeinstall2]

Makes sense. Thanks Irina.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[imiller0]

/jira refresh

[openshift-ci-robot]

@imiller0: This pull request references Jira Issue OCPBUGS-62684, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bazem@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[imiller0]

We should review if these are still necessary. The default runtime switched to crun in 4.18. Any newly installed cluster 4.18+ will already have crun set. Older clusters will stay with their configuration. Now that main branch is reflecting 4.22 can we safely assume that all clusters will have gone through an upgrade which includes the policy to set crun? If so I believe we can remove these CRs as redundant.
https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/release_notes/ocp-4-18-release-notes#ocp-release-notes-nodes-crun-default_release-notes
https://github.com/openshift/machine-config-operator/pull/4437/changes