Open
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ffromani
force-pushed
the
rewrite-commit-msg-hook
branch
from
72883e2 to
974c6a7
Compare
shajmakh
force-pushed
the
rewrite-commit-msg-hook
branch
from
b10c120 to
4d1195d
Compare
shajmakh
force-pushed
the
rewrite-commit-msg-hook
branch
from
cac9a5f to
2a0ad33
Compare
shajmakh
force-pushed
the
rewrite-commit-msg-hook
branch
from
2a0ad33 to
c3b0643
Compare
shajmakh
force-pushed
the
rewrite-commit-msg-hook
branch
from
c3b0643 to
26569f6
Compare
shajmakh
force-pushed
the
rewrite-commit-msg-hook
branch
5 times, most recently
from
e993b8d to
42e6117
Compare
Member
shajmakh
changed the title
Member
|
@ffromani this should be ready for review |
shajmakh
force-pushed
the
rewrite-commit-msg-hook
branch
4 times, most recently
from
5ea87c3 to
7dd4bc3
Compare
Rewrite the script that verifies the commit message in go, taking into consideration the project rules described in RESYNC.README.md. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
Now that we have a tool that verifies a single commit message, enhance it even more to deal with N commits and do the rest of the verification logic. From a real example, it turns out that the Signed-off line is prefixed with spaces, thus also fix the isKonflux method to deal with this input. Assisted-by: Cursor v1.2.2 AI-Attribution: AIA HAb Hin R Cursor v1.2.2 v1.0 Signed-off-by: Shereen Haj <shajmakh@redhat.com>
Update to the latest for checkout and go setup. https://github.com/actions/setup-go/tags https://github.com/actions/checkout/tags Signed-off-by: Shereen Haj <shajmakh@redhat.com>
Isolate the commits verification and support running it on all product branches. Assisted-by: Cursor v1.2.2 AI-Attribution: AIA Primarily human, Content edits, Human-initiated, Reviewed, cursor v1.2.2 v1.0 Signed-off-by: Shereen Haj <shajmakh@redhat.com>
To ensure nothing gets merged broken. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the script that verifies the commit message in go, taking into
consideration the project rules described in RESYNC.README.md.