Skip to content

spanorm is runable#14

Merged
LouisK92 merged 8 commits intomainfrom
spanorm
Jul 9, 2025
Merged

spanorm is runable#14
LouisK92 merged 8 commits intomainfrom
spanorm

Conversation

@Kraftfahrzeughaftpflichtversicherung
Copy link
Contributor

No description provided.

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kraftfahrzeughaftpflichtversicherung !

Thanks for your contribution!

Could you make the following changes?

  • Remove the .RData and .Rhistory files from this PR
  • One of the tests is failing. Could you run viash test src/methods_normalization/spanorm/config.vsh.yaml and fix any issues that show up?

Thanks!

@LouisK92
Copy link
Contributor

LouisK92 commented Apr 4, 2025

@Kraftfahrzeughaftpflichtversicherung check out the changes that I added, with viash test src/methods_normalization/spanorm/config.vsh.yaml you now only get the error that the output doesn't have the correct layers.
Note that the output needs to be exactly as the input, just that you add the normalised data in adata.layers['normalized'] - can you please adjust this, such that the output is correct?

@LouisK92 LouisK92 merged commit 11d6913 into main Jul 9, 2025
2 checks passed
@LouisK92 LouisK92 deleted the spanorm branch July 9, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants