Enable annotating contributor roles#75
Closed
cthoyt wants to merge 24 commits intoopenjournals:mainfrom
Closed
Conversation
Contributor
Author
|
@tarleb this one is also ready for a first review |
tarleb
reviewed
Sep 4, 2024
Collaborator
tarleb
left a comment
tarleb
left a comment
There was a problem hiding this comment.
Super neat, thank you! I added a few inline comments.
| for _, roleDict in ipairs(author.roles) do | ||
| role = roleDict.type[1].text | ||
| if invalidRole(role) then | ||
| error("invalid role for author " .. author.name .. ": " .. role) |
Collaborator
There was a problem hiding this comment.
I'm not sure how errors are handled by editorial-bot. @xuanxu, what happens if the conversion fails, would the authors see this error message?
cthoyt
force-pushed
the
contributor-roles
branch
from
76604f4 to
e7d5fe3
Compare
cthoyt
force-pushed
the
contributor-roles
branch
from
e7d5fe3 to
8622e3e
Compare
cthoyt
added a commit
to y0-causal-inference/y0
that referenced
this pull request
Sep 8, 2024
Contributor
Author
|
closing this one in favor of #87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73
This PR enables annotating author roles using the Contribution Role Taxonomy (CRediT). It also enables (optionally) annotating the contribution degree, as suggested by JATS.
It does the following:
default.latex(after reference list)preprint.latex(after reference list)Demo
Here's what this looks like at the end of the main PDF build:
Future Work
Future work for future PRs: