8370635: [lworld] TypeName.super.[TypeArguments] Identifier cannot occur in prologue

[vicente-romero-oracle]

Code like:

class Test {
    static boolean testMethod() { return true; }
    Test() {}
    Test(int a) {
        Test.this.testMethod();
        this();
    }
}

or:

class Super {
    static <T> void m() {}
}

class Test extends Super {
    Test() {
        Test.super.<String>m();
        super();
    }
}

shouldn't be allowed in prologue. Javac was not checking static method invocations in the prologue correctly. This fix should solve this issue,

TIA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8370635: [lworld] TypeName.super.[TypeArguments] Identifier cannot occur in prologue (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1779/head:pull/1779
$ git checkout pull/1779

Update a local copy of the PR:
$ git checkout pull/1779
$ git pull https://git.openjdk.org/valhalla.git pull/1779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1779

View PR using the GUI difftool:
$ git pr show -t 1779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1779.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (1d38bf09)

[liach]

Is there a reason we only restrict MTH? We can write code like:

class A { static int a = 5; }
class B extends A { B() { IO.println(B.super.a); } }

Wonder if we should block B.super.a style stuff in early construction.