Merge lworld #1688
Draft
Merge lworld #1688
+670,587
−516,421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Reviewed-by: prr
Reviewed-by: prr
Reviewed-by: ayang, iwalulya, fandreuzzi
Reviewed-by: mullan
…otAndRemainder Reviewed-by: darcy
Reviewed-by: gli, iwalulya
…l.commonPool() Reviewed-by: vklang, alanb
…-512) Reviewed-by: kvn, roland
Reviewed-by: mdoerr
Reviewed-by: kvn, vlivanov
Reviewed-by: kvn, roland
Reviewed-by: naoto
…entire file at once Reviewed-by: erikj
Reviewed-by: rgiulietti
… since jdk-22+8 Reviewed-by: phubner, fparain
Reviewed-by: phubner, fparain
Reviewed-by: liach
Reviewed-by: shade, fandreuzzi
…tions Reviewed-by: alanb, iris
Reviewed-by: alanb
…rowthTriggers.java Reviewed-by: wkemper
Reviewed-by: kizune, dnguyen
Reviewed-by: almatvee
Reviewed-by: shade, apangin, dlong
… and idom lazy updating/forwarding of ctrl and idom via dead ctrl nodes Reviewed-by: chagedorn, thartmann
…perclass field Reviewed-by: liach
…ts when comparing directory structure Reviewed-by: rriggs, liach
Reviewed-by: rriggs, liach, fparain
…ntext Reviewed-by: liach
…y available if it is exact Reviewed-by: thartmann
Reviewed-by: rriggs
…merge Reviewed-by: chagedorn
Reviewed-by: chagedorn
Reviewed-by: coleenp, heidinga, phubner
…ilure Reviewed-by: lfoltan
Reviewed-by: phubner, rriggs
…xpected IllegalArgumentException Reviewed-by: liach
…uring deoptimization Reviewed-by: thartmann
Co-authored-by: Frederic Parain <[email protected]> Reviewed-by: coleenp, thartmann
…': conversion from 'size_t' to 'int' Reviewed-by: thartmann
Reviewed-by: heidinga, coleenp
…by JDK-8371915 Reviewed-by: amenkov
…ut.java Reviewed-by: chagedorn
Reviewed-by: rriggs
Reviewed-by: dsimms
…e the extension space Reviewed-by: mhaessig, thartmann
…va fails with segfault in C1 compiled code on aarch64 Reviewed-by: thartmann
…mentWithGCBarrierTests.java fails with --enable-preview Reviewed-by: thartmann, chagedorn
…ment the offset when iterating over segments Reviewed-by: liach, rriggs
Reviewed-by: liach
…Oop.cpp Reviewed-by: fparain
Reviewed-by: liach
…th -XX:+UseAtomicValueFlattening Reviewed-by: liach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge from lworld in lworld+vector branch.
Apart from the usual merge conflict resolution, the patch also contains bug fixes for some special handling around multifields.
To segregate the code changes and maintain the history[1][2][3][4][5], these bug fixes were initially checked into a temporary private merge branch and are now part of the merge.
Validation: Status
[1] Special copy constructor used for initializing base and synthetic multifields
jatin-bhateja@0fe3153
[2] Fix ciField population for multifields
jatin-bhateja@4a26aff
[3] Multifield handling during type domain buildup
jatin-bhateja@74ca024
[4] prevent store forwarding across CPU memory barrier
jatin-bhateja@cfc71ac
[5] Fix to accommodate additional padding during offset computation of multifields
jatin-bhateja@75ec629
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1688/head:pull/1688$ git checkout pull/1688Update a local copy of the PR:
$ git checkout pull/1688$ git pull https://git.openjdk.org/valhalla.git pull/1688/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1688View PR using the GUI difftool:
$ git pr show -t 1688Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1688.diff