Skip to content

#1 abstract test a.1 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LibbyShihh wants to merge 6 commits into
base: main
Choose a base branch
from
Open

#1 abstract test a.1 #67

LibbyShihh wants to merge 6 commits into from

Conversation

@LibbyShihh
Copy link
Member

@LibbyShihh LibbyShihh commented Mar 7, 2025 •
edited by dstenger
Loading

Closes #1

@LibbyShihh
#1 Implement A.1.1 Abstract Test for Requirement Map Operation
487eed2 
- Implemented abstract test A.1.1 and its integration test (IT)
- Added test URL for execution
- Defined execution order
@LibbyShihh
Resolve mvn build issues by updating test suite and using test count …
dedfe6c 
…variables

- Updated test suite from Features to Maps to fix mvn build error
- Modified testng.xml
- Replaced hardcoded test counts with variables to prevent build failures due to mismatched results
@dstenger dstenger added this to CITE Mar 13, 2025
@github-project-automation github-project-automation bot moved this to To do in CITE Mar 13, 2025
@dstenger dstenger moved this from To do to In progress in CITE Mar 13, 2025
@bpross-52n bpross-52n self-requested a review March 21, 2025 08:42
bpross-52n
bpross-52n requested changes Mar 21, 2025
View reviewed changes
Copy link

@bpross-52n bpross-52n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a build error due to formatting violations. Running mvn spring-javaformat:apply should fix this.

dstenger
dstenger reviewed Mar 26, 2025
View reviewed changes
src/main/java/org/opengis/cite/ogcapimaps10/conformance/core/MapOperation.java Outdated
@Test(description = "Implements A.1.1. Abstract Test for Requirement Map Operation (Requirement /req/core/map-op)")
public void verifyMapRetrievalOperation() throws Exception {
ObjectMapper objectMapper = new ObjectMapper();
String apiUrl = rootUri.toString() + "/collections?f=json";
Copy link

@dstenger dstenger Mar 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use the the Accept header (application/json) instead of f=json?

@LibbyShihh
fix:
b6f20ec 
- Resolve formatting violations
- Use Accept header (application/json) for JSON response negotiation

Closes #1
@LibbyShihh
refactor:
a8a6b4d 
- Support relative map URLs
- Add noOfCollections parameter to limit number of tested collections
- Set connection and read timeout to avoid hanging on unresponsive map URLs
@ghobona
Copy link

ghobona commented Sep 29, 2025

  • @ghobona To check the formatting issue mvn spring-javaformat:apply

@ghobona ghobona self-assigned this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpross-52n bpross-52n bpross-52n requested changes

+1 more reviewer

@dstenger dstenger dstenger left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ghobona ghobona

Labels

None yet

Projects

CITE
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A.1.1. Abstract Test for Requirement Map Operation (Abstract test A.1)

4 participants

@LibbyShihh @ghobona @dstenger @bpross-52n