Skip to content

Update Help Modal description following SAM RNG removal in #2665#2692

Merged
evanpelle merged 2 commits intoopenfrontio:mainfrom
Aotumuri:fix-sam-desc
Dec 27, 2025
Merged

Update Help Modal description following SAM RNG removal in #2665#2692
evanpelle merged 2 commits intoopenfrontio:mainfrom
Aotumuri:fix-sam-desc

Conversation

@Aotumuri
Copy link
Member

Description:

Updates the help modal text to reflect the removal of SAM RNG in #2665.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

Aotumuri

@Aotumuri Aotumuri requested a review from a team as a code owner December 25, 2025 12:21
@CLAassistant
Copy link

CLAassistant commented Dec 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iiamlewis
❌ Aotumuri
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

Walkthrough

The English language resource file was updated to simplify the SAM Launcher description. Detailed hit probability information for specific bomb types was removed, leaving only the range and 7.5-second cooldown details in the final description.

Changes

Cohort / File(s) Summary
Language Resource Update
resources/lang/en.json
Simplified SAM Launcher description (build_menu.desc → build_sam_desc): removed bomb-specific hit chances for Atom Bomb, Hydrogen Bomb, and MIRV Warheads; retained range and cooldown information

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • evanpelle

Poem

🚀 The SAM launcher's tale grows lean,
Hit chances fade, a cleaner scene.
Range and cooldown, crisp and clear—
Complexity gone, precision near! ✨

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating help modal descriptions following SAM RNG removal referenced in PR #2665.
Description check ✅ Passed The description is directly related to the changeset, explaining that help modal text was updated to reflect SAM RNG removal from PR #2665.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28e22c9 and 82013f5.

📒 Files selected for processing (1)
  • resources/lang/en.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: DevelopingTom
Repo: openfrontio/OpenFrontIO PR: 1900
File: src/core/execution/SAMLauncherExecution.ts:103-111
Timestamp: 2025-08-24T11:13:08.495Z
Learning: In SAMLauncherExecution.ts, the cached target bug can only occur if: 1) SAM is not on cooldown when nuke is in range, 2) SAM goes on cooldown right after computing trajectory, 3) SAM becomes available again before nuke explodes. This is not possible with current cooldown values but the fix is still valuable for robustness.
📚 Learning: 2025-08-24T11:13:08.495Z
Learnt from: DevelopingTom
Repo: openfrontio/OpenFrontIO PR: 1900
File: src/core/execution/SAMLauncherExecution.ts:103-111
Timestamp: 2025-08-24T11:13:08.495Z
Learning: In SAMLauncherExecution.ts, the cached target bug can only occur if: 1) SAM is not on cooldown when nuke is in range, 2) SAM goes on cooldown right after computing trajectory, 3) SAM becomes available again before nuke explodes. This is not possible with current cooldown values but the fix is still valuable for robustness.

Applied to files:

  • resources/lang/en.json

@iiamlewis iiamlewis added the Gameplay Features that affect gameplay label Dec 25, 2025
@iiamlewis iiamlewis moved this from Triage to Peer Review in OpenFront Release Management Dec 25, 2025
@iiamlewis iiamlewis added this to the v29 milestone Dec 25, 2025
@iiamlewis
Copy link
Contributor

Can you review base branch errors

@Aotumuri
Copy link
Member Author

@iiamlewis
If the issue you mentioned is about other language files flagged by CodeRabbit, I don’t think it needs to be addressed here.
Some languages have remained unupdated across other PRs, and I plan to clean up long-unmaintained languages in separate PRs.

Copy link
Collaborator

@evanpelle evanpelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@github-project-automation github-project-automation bot moved this from Peer Review to Final Review in OpenFront Release Management Dec 27, 2025
@evanpelle evanpelle merged commit c9d9a32 into openfrontio:main Dec 27, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Final Review to Complete in OpenFront Release Management Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gameplay Features that affect gameplay

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants