Skip to content

ofxAssimp Naming Convention #8367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickHardeman merged 7 commits into from
Mar 11, 2025
Merged

ofxAssimp Naming Convention #8367

NickHardeman merged 7 commits into from
Mar 11, 2025

Conversation

@NickHardeman
Copy link
Contributor

@NickHardeman NickHardeman commented Mar 10, 2025

  • Reduce naming complexity from ofx::assimp to ofxAssimp.
  • Changed ofx::assimp::Model to ofxAssimp::Scene for better representation of functionality and more closely aligned to the underlying assimp scene.
  • Updated legacy c import api calls to newer c++ importer.
  • Added ofxAssimp.h file for importing the ofxAssimpScene file.
  • Updated ofxAssimp examples to reflect changes.

Further discussion here: #8354

@NickHardeman NickHardeman changed the title Assimp Naming Convention ofxAssimp Naming Convention Mar 10, 2025
@NickHardeman NickHardeman mentioned this pull request Mar 10, 2025
Closed
@ofTheo
Copy link
Member

ofTheo commented Mar 11, 2025

Looks good to me @NickHardeman
Merge when your ready :)

@NickHardeman NickHardeman merged commit 37eb57b into openframeworks:master Mar 11, 2025
15 checks passed
@NickHardeman NickHardeman deleted the assimp-namespace branch March 11, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickHardeman @ofTheo