-
Notifications
You must be signed in to change notification settings - Fork 62
Update .NET client WriteAuthorizationModel signature #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughUpdated the .NET client template to change WriteAuthorizationModel’s parameter type from ClientWriteAuthorizationModelRequest to WriteAuthorizationModelRequest. Added a README example demonstrating constructing WriteAuthorizationModelRequest via FromJson and calling WriteAuthorizationModel. No other control-flow or call-site logic changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
config/clients/dotnet/template/README_calling_api.mustache (1)
98-135: Update example to use WriteAuthorizationModelRequest.The example on line 98 constructs a
ClientWriteAuthorizationModelRequest, but theWriteAuthorizationModelmethod now acceptsWriteAuthorizationModelRequest(as changed inconfig/clients/dotnet/template/Client/Client.mustacheline 114). This creates a type mismatch.Apply this diff to fix the type:
-var body = new ClientWriteAuthorizationModelRequest { +var body = new WriteAuthorizationModelRequest { SchemaVersion = "1.1",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/clients/dotnet/template/Client/Client.mustache(1 hunks)config/clients/dotnet/template/README_calling_api.mustache(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
config/**/*.mustache
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Validate mustache syntax and variable references across all template files, including CHANGELOG.md.mustache
Files:
config/clients/dotnet/template/Client/Client.mustacheconfig/clients/dotnet/template/README_calling_api.mustache
config/**/*.{json,mustache}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Never hardcode API keys or credentials in configuration or template files
Files:
config/clients/dotnet/template/Client/Client.mustacheconfig/clients/dotnet/template/README_calling_api.mustache
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-and-test-java-sdk
🔇 Additional comments (1)
config/clients/dotnet/template/README_calling_api.mustache (1)
137-144: LGTM! Clear documentation of the FromJson usage.The new example effectively demonstrates how to deserialize an authorization model from JSON and pass it directly to
WriteAuthorizationModel, which aligns with the updated method signature.
Summary
WriteAuthorizationModelhelper to accept the baseWriteAuthorizationModelRequestWriteAuthorizationModelRequest.FromJsonTesting
https://chatgpt.com/codex/tasks/task_e_68de6d7d64cc8323b2a35248d27fa85c
Summary by CodeRabbit
Breaking Changes
Documentation