Skip to content

Conversation

@aaguiarz
Copy link
Member

@aaguiarz aaguiarz commented Oct 2, 2025

Summary

  • allow the generated .NET client's WriteAuthorizationModel helper to accept the base WriteAuthorizationModelRequest
  • document how to submit authorization models read from JSON by using WriteAuthorizationModelRequest.FromJson

Testing

  • not run

https://chatgpt.com/codex/tasks/task_e_68de6d7d64cc8323b2a35248d27fa85c

Summary by CodeRabbit

  • Breaking Changes

    • .NET client: WriteAuthorizationModel now accepts WriteAuthorizationModelRequest instead of ClientWriteAuthorizationModelRequest. Update your integrations to construct and pass the new request type.
  • Documentation

    • Added an example showing how to deserialize an authorization model JSON via WriteAuthorizationModelRequest.FromJson and pass it directly to WriteAuthorizationModel.

@aaguiarz aaguiarz requested a review from a team as a code owner October 2, 2025 12:37
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updated the .NET client template to change WriteAuthorizationModel’s parameter type from ClientWriteAuthorizationModelRequest to WriteAuthorizationModelRequest. Added a README example demonstrating constructing WriteAuthorizationModelRequest via FromJson and calling WriteAuthorizationModel. No other control-flow or call-site logic changes.

Changes

Cohort / File(s) Summary of changes
Client Template
config/clients/dotnet/template/Client/Client.mustache
Changed method signature to accept WriteAuthorizationModelRequest instead of ClientWriteAuthorizationModelRequest for WriteAuthorizationModel. Other parameters and pass-through call remain the same.
Docs Template
config/clients/dotnet/template/README_calling_api.mustache
Added example showing deserializing model JSON with WriteAuthorizationModelRequest.FromJson and passing it to WriteAuthorizationModel. No logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title directly and succinctly conveys the primary change—modifying the .NET client’s WriteAuthorizationModel method signature—without unnecessary detail or ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
config/clients/dotnet/template/README_calling_api.mustache (1)

98-135: Update example to use WriteAuthorizationModelRequest.

The example on line 98 constructs a ClientWriteAuthorizationModelRequest, but the WriteAuthorizationModel method now accepts WriteAuthorizationModelRequest (as changed in config/clients/dotnet/template/Client/Client.mustache line 114). This creates a type mismatch.

Apply this diff to fix the type:

-var body = new ClientWriteAuthorizationModelRequest {
+var body = new WriteAuthorizationModelRequest {
     SchemaVersion = "1.1",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed2b892 and 8c8f638.

📒 Files selected for processing (2)
  • config/clients/dotnet/template/Client/Client.mustache (1 hunks)
  • config/clients/dotnet/template/README_calling_api.mustache (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
config/**/*.mustache

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Validate mustache syntax and variable references across all template files, including CHANGELOG.md.mustache

Files:

  • config/clients/dotnet/template/Client/Client.mustache
  • config/clients/dotnet/template/README_calling_api.mustache
config/**/*.{json,mustache}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Never hardcode API keys or credentials in configuration or template files

Files:

  • config/clients/dotnet/template/Client/Client.mustache
  • config/clients/dotnet/template/README_calling_api.mustache
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-and-test-java-sdk
🔇 Additional comments (1)
config/clients/dotnet/template/README_calling_api.mustache (1)

137-144: LGTM! Clear documentation of the FromJson usage.

The new example effectively demonstrates how to deserialize an authorization model from JSON and pass it directly to WriteAuthorizationModel, which aligns with the updated method signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants